All of lore.kernel.org
 help / color / mirror / Atom feed
* [ogabbay:habanalabs-next 47/47] drivers/misc/habanalabs/common/habanalabs_ioctl.c:135 events_info() warn: maybe return -EFAULT instead of the bytes remaining?
@ 2022-05-11  9:40 ` Dan Carpenter
  0 siblings, 0 replies; 5+ messages in thread
From: kernel test robot @ 2022-05-10  0:01 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 3515 bytes --]

CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-kernel(a)vger.kernel.org
TO: Tal Cohen <talcohen@habana.ai>
CC: Oded Gabbay <ogabbay@kernel.org>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/ogabbay/linux.git habanalabs-next
head:   20c59ac5d71e766235e74f353b74e60facd733c8
commit: 20c59ac5d71e766235e74f353b74e60facd733c8 [47/47] habanalabs: add support for notification via eventfd
:::::: branch date: 16 hours ago
:::::: commit date: 16 hours ago
config: x86_64-randconfig-m001-20220509 (https://download.01.org/0day-ci/archive/20220510/202205100736.Y0Vi5Fcf-lkp(a)intel.com/config)
compiler: gcc-11 (Debian 11.2.0-20) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/misc/habanalabs/common/habanalabs_ioctl.c:135 events_info() warn: maybe return -EFAULT instead of the bytes remaining?

vim +135 drivers/misc/habanalabs/common/habanalabs_ioctl.c

d8dd7b0a81cc19 drivers/misc/habanalabs/habanalabs_ioctl.c        Oded Gabbay 2019-02-16  118  
20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  119  static int events_info(struct hl_fpriv *hpriv, struct hl_info_args *args)
20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  120  {
20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  121  	int rc;
20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  122  	u32 max_size = args->return_size;
20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  123  	u64 events_mask;
20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  124  	void __user *out = (void __user *) (uintptr_t) args->return_pointer;
20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  125  
20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  126  	if ((max_size < sizeof(u64)) || (!out))
20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  127  		return -EINVAL;
20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  128  
20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  129  	mutex_lock(&hpriv->notifier_event.lock);
20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  130  	events_mask = hpriv->notifier_event.events_mask;
20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  131  	hpriv->notifier_event.events_mask = 0;
20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  132  	mutex_unlock(&hpriv->notifier_event.lock);
20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  133  
20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  134  	rc = copy_to_user(out, &events_mask, sizeof(u64));
20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28 @135  	return rc;
20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  136  }
20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  137  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [ogabbay:habanalabs-next 47/47] drivers/misc/habanalabs/common/habanalabs_ioctl.c:135 events_info() warn: maybe return -EFAULT instead of the bytes remaining?
@ 2022-05-11  9:40 ` Dan Carpenter
  0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2022-05-11  9:40 UTC (permalink / raw)
  To: kbuild, Tal Cohen; +Cc: lkp, kbuild-all, linux-kernel, Oded Gabbay

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/ogabbay/linux.git habanalabs-next
head:   20c59ac5d71e766235e74f353b74e60facd733c8
commit: 20c59ac5d71e766235e74f353b74e60facd733c8 [47/47] habanalabs: add support for notification via eventfd
config: x86_64-randconfig-m001-20220509 (https://download.01.org/0day-ci/archive/20220510/202205100736.Y0Vi5Fcf-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.2.0-20) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/misc/habanalabs/common/habanalabs_ioctl.c:135 events_info() warn: maybe return -EFAULT instead of the bytes remaining?

vim +135 drivers/misc/habanalabs/common/habanalabs_ioctl.c

20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  119  static int events_info(struct hl_fpriv *hpriv, struct hl_info_args *args)
20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  120  {
20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  121  	int rc;
20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  122  	u32 max_size = args->return_size;
20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  123  	u64 events_mask;
20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  124  	void __user *out = (void __user *) (uintptr_t) args->return_pointer;
20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  125  
20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  126  	if ((max_size < sizeof(u64)) || (!out))
20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  127  		return -EINVAL;
20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  128  
20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  129  	mutex_lock(&hpriv->notifier_event.lock);
20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  130  	events_mask = hpriv->notifier_event.events_mask;
20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  131  	hpriv->notifier_event.events_mask = 0;
20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  132  	mutex_unlock(&hpriv->notifier_event.lock);
20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  133  
20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  134  	rc = copy_to_user(out, &events_mask, sizeof(u64));
20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28 @135  	return rc;

copy_to_user() returns the number of bytes remaining (positive).  This
should be:

	if (copy_to_user(out, &events_mask, sizeof(u64)))
		return -EFAULT;

	return 0;

20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  136  }

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [ogabbay:habanalabs-next 47/47] drivers/misc/habanalabs/common/habanalabs_ioctl.c:135 events_info() warn: maybe return -EFAULT instead of the bytes remaining?
@ 2022-05-11  9:40 ` Dan Carpenter
  0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2022-05-11  9:40 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 3267 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/ogabbay/linux.git habanalabs-next
head:   20c59ac5d71e766235e74f353b74e60facd733c8
commit: 20c59ac5d71e766235e74f353b74e60facd733c8 [47/47] habanalabs: add support for notification via eventfd
config: x86_64-randconfig-m001-20220509 (https://download.01.org/0day-ci/archive/20220510/202205100736.Y0Vi5Fcf-lkp(a)intel.com/config)
compiler: gcc-11 (Debian 11.2.0-20) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/misc/habanalabs/common/habanalabs_ioctl.c:135 events_info() warn: maybe return -EFAULT instead of the bytes remaining?

vim +135 drivers/misc/habanalabs/common/habanalabs_ioctl.c

20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  119  static int events_info(struct hl_fpriv *hpriv, struct hl_info_args *args)
20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  120  {
20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  121  	int rc;
20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  122  	u32 max_size = args->return_size;
20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  123  	u64 events_mask;
20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  124  	void __user *out = (void __user *) (uintptr_t) args->return_pointer;
20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  125  
20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  126  	if ((max_size < sizeof(u64)) || (!out))
20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  127  		return -EINVAL;
20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  128  
20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  129  	mutex_lock(&hpriv->notifier_event.lock);
20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  130  	events_mask = hpriv->notifier_event.events_mask;
20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  131  	hpriv->notifier_event.events_mask = 0;
20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  132  	mutex_unlock(&hpriv->notifier_event.lock);
20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  133  
20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  134  	rc = copy_to_user(out, &events_mask, sizeof(u64));
20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28 @135  	return rc;

copy_to_user() returns the number of bytes remaining (positive).  This
should be:

	if (copy_to_user(out, &events_mask, sizeof(u64)))
		return -EFAULT;

	return 0;

20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  136  }

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [ogabbay:habanalabs-next 47/47] drivers/misc/habanalabs/common/habanalabs_ioctl.c:135 events_info() warn: maybe return -EFAULT instead of the bytes remaining?
  2022-05-11  9:40 ` Dan Carpenter
@ 2022-05-11  9:55   ` Oded Gabbay
  -1 siblings, 0 replies; 5+ messages in thread
From: Oded Gabbay @ 2022-05-11  9:55 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: kbuild, Tal Cohen, kbuild test robot, kbuild-all,
	Linux-Kernel@Vger. Kernel. Org

On Wed, May 11, 2022 at 12:41 PM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/ogabbay/linux.git habanalabs-next
> head:   20c59ac5d71e766235e74f353b74e60facd733c8
> commit: 20c59ac5d71e766235e74f353b74e60facd733c8 [47/47] habanalabs: add support for notification via eventfd
> config: x86_64-randconfig-m001-20220509 (https://download.01.org/0day-ci/archive/20220510/202205100736.Y0Vi5Fcf-lkp@intel.com/config)
> compiler: gcc-11 (Debian 11.2.0-20) 11.2.0
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> smatch warnings:
> drivers/misc/habanalabs/common/habanalabs_ioctl.c:135 events_info() warn: maybe return -EFAULT instead of the bytes remaining?
>
> vim +135 drivers/misc/habanalabs/common/habanalabs_ioctl.c
>
> 20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  119  static int events_info(struct hl_fpriv *hpriv, struct hl_info_args *args)
> 20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  120  {
> 20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  121    int rc;
> 20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  122    u32 max_size = args->return_size;
> 20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  123    u64 events_mask;
> 20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  124    void __user *out = (void __user *) (uintptr_t) args->return_pointer;
> 20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  125
> 20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  126    if ((max_size < sizeof(u64)) || (!out))
> 20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  127            return -EINVAL;
> 20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  128
> 20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  129    mutex_lock(&hpriv->notifier_event.lock);
> 20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  130    events_mask = hpriv->notifier_event.events_mask;
> 20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  131    hpriv->notifier_event.events_mask = 0;
> 20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  132    mutex_unlock(&hpriv->notifier_event.lock);
> 20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  133
> 20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  134    rc = copy_to_user(out, &events_mask, sizeof(u64));
> 20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28 @135    return rc;
>
> copy_to_user() returns the number of bytes remaining (positive).  This
> should be:
>
>         if (copy_to_user(out, &events_mask, sizeof(u64)))
>                 return -EFAULT;
>
>         return 0;
>
> 20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  136  }
>
> --
> 0-DAY CI Kernel Test Service
> https://01.org/lkp
>

Correct, thanks, I'll fix it.
Oded

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [ogabbay:habanalabs-next 47/47] drivers/misc/habanalabs/common/habanalabs_ioctl.c:135 events_info() warn: maybe return -EFAULT instead of the bytes remaining?
@ 2022-05-11  9:55   ` Oded Gabbay
  0 siblings, 0 replies; 5+ messages in thread
From: Oded Gabbay @ 2022-05-11  9:55 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 3515 bytes --]

On Wed, May 11, 2022 at 12:41 PM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/ogabbay/linux.git habanalabs-next
> head:   20c59ac5d71e766235e74f353b74e60facd733c8
> commit: 20c59ac5d71e766235e74f353b74e60facd733c8 [47/47] habanalabs: add support for notification via eventfd
> config: x86_64-randconfig-m001-20220509 (https://download.01.org/0day-ci/archive/20220510/202205100736.Y0Vi5Fcf-lkp(a)intel.com/config)
> compiler: gcc-11 (Debian 11.2.0-20) 11.2.0
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> smatch warnings:
> drivers/misc/habanalabs/common/habanalabs_ioctl.c:135 events_info() warn: maybe return -EFAULT instead of the bytes remaining?
>
> vim +135 drivers/misc/habanalabs/common/habanalabs_ioctl.c
>
> 20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  119  static int events_info(struct hl_fpriv *hpriv, struct hl_info_args *args)
> 20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  120  {
> 20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  121    int rc;
> 20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  122    u32 max_size = args->return_size;
> 20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  123    u64 events_mask;
> 20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  124    void __user *out = (void __user *) (uintptr_t) args->return_pointer;
> 20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  125
> 20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  126    if ((max_size < sizeof(u64)) || (!out))
> 20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  127            return -EINVAL;
> 20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  128
> 20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  129    mutex_lock(&hpriv->notifier_event.lock);
> 20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  130    events_mask = hpriv->notifier_event.events_mask;
> 20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  131    hpriv->notifier_event.events_mask = 0;
> 20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  132    mutex_unlock(&hpriv->notifier_event.lock);
> 20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  133
> 20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  134    rc = copy_to_user(out, &events_mask, sizeof(u64));
> 20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28 @135    return rc;
>
> copy_to_user() returns the number of bytes remaining (positive).  This
> should be:
>
>         if (copy_to_user(out, &events_mask, sizeof(u64)))
>                 return -EFAULT;
>
>         return 0;
>
> 20c59ac5d71e76 drivers/misc/habanalabs/common/habanalabs_ioctl.c Tal Cohen   2022-04-28  136  }
>
> --
> 0-DAY CI Kernel Test Service
> https://01.org/lkp
>

Correct, thanks, I'll fix it.
Oded

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-05-11  9:57 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-10  0:01 [ogabbay:habanalabs-next 47/47] drivers/misc/habanalabs/common/habanalabs_ioctl.c:135 events_info() warn: maybe return -EFAULT instead of the bytes remaining? kernel test robot
2022-05-11  9:40 ` Dan Carpenter
2022-05-11  9:40 ` Dan Carpenter
2022-05-11  9:55 ` Oded Gabbay
2022-05-11  9:55   ` Oded Gabbay

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.