From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B0C16C433F5 for ; Tue, 7 Dec 2021 20:26:39 +0000 (UTC) Received: from localhost ([::1]:39548 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1muh2s-0007H5-Je for qemu-devel@archiver.kernel.org; Tue, 07 Dec 2021 15:26:38 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34434) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1muh0f-0005F0-1B for qemu-devel@nongnu.org; Tue, 07 Dec 2021 15:24:21 -0500 Received: from [2a00:1450:4864:20::32b] (port=55029 helo=mail-wm1-x32b.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1muh0d-00071Q-0u for qemu-devel@nongnu.org; Tue, 07 Dec 2021 15:24:20 -0500 Received: by mail-wm1-x32b.google.com with SMTP id i12so253697wmq.4 for ; Tue, 07 Dec 2021 12:24:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=he1+55OMQrhPzn/Du0g9rhBuLpjE5wn6quFfOCTwcD0=; b=KNQjSbf/TdPbqMQEq0JvNed7qlINYd9P8mcpAo/fjXBCIXA/bzc000NI9Y8fzR8P2d UsJPqUY6fnHE9pebFfnLvZGuBRynz30nkX+4sPm2l0Sup51Bnos+JbCJWpWtTuhpMHda V8CAqU6f0oVJN18ir8pOjy6wQQl5X/AZ9t1woQuxpP49oQvtCxKXeaypi13v45ngqaeB wi3RN5HrklXeJvb4c7wh/lvbY0Qgs//+b/aWkqz6EU2EqGdi5/vVlWzhcQQsU18CKMy7 SDjkDNWF1oPBR2z138EY7hprF7dF4zgRK77MFeKve2gKk71u85eN4mOc5doAt+qYNvJf RvKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=he1+55OMQrhPzn/Du0g9rhBuLpjE5wn6quFfOCTwcD0=; b=vyl8re+tfQ4IV6MTfO0sDuO8ixj0rhEHHOA0jeO8kYjdmIirVtUkS5G89mzP4bhdQO Y3AvB6JPOhuy6GQxJd598w8mLob1xG7SAC2gDtWZyjwoVfrVZOrhSrC+BCE20OPa3dUP m0DGDxHqI/6D/pG8tyKvoqDvmava474/tLwWJF9N/2TZ/oWD39GO9UYv9vsWePlSv1Ut icZfQeJtxX1G7RWFqOSZl0IJhDf3ui9oy1hYD3zuACGxm52IuWxJdG07q7BVXcnk4YfP bf/4S6/0czWQ7rD14HBwuCnz4fSLj5iOOMA90K2j9LC2ibE5sgL4ifhWi12J5NQVDEeh DqNw== X-Gm-Message-State: AOAM531jjVyhoiOPhUMPpZtMs4/TKe8wGV6BRaAcd01BpSMcXnBBrVxF T6n9l84xkO/uEe+ADwlh2W9cHp8SqxA1YrH8/NCQrw== X-Google-Smtp-Source: ABdhPJwvBZb6K9XZdtCjqpOh5vtxVaLyY9ZeXnyeZMoOmGWLvRVVL6cvb8fASljARtpqZjt+1Jpbe4XksKQkCvFB8GE= X-Received: by 2002:a1c:7f43:: with SMTP id a64mr10069090wmd.133.1638908657078; Tue, 07 Dec 2021 12:24:17 -0800 (PST) MIME-Version: 1.0 References: <20211207094427.3473-1-damien.hedde@greensocs.com> <7c9d97ab-1662-106a-5b51-630a4d2375cf@greensocs.com> In-Reply-To: <7c9d97ab-1662-106a-5b51-630a4d2375cf@greensocs.com> From: Peter Maydell Date: Tue, 7 Dec 2021 20:24:06 +0000 Message-ID: Subject: Re: [PATCH v2 for 6.2?] gicv3: fix ICH_MISR's LRENP computation To: Damien Hedde Content-Type: text/plain; charset="UTF-8" X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::32b (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x32b.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Brian Cain , Sid Manning , Carl van Schaik , "shashi.mallela@linaro.org" , "qemu-devel@nongnu.org" , Taylor Simpson , "qemu-arm@nongnu.org" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, 7 Dec 2021 at 15:49, Damien Hedde wrote: > > > > On 12/7/21 16:45, Peter Maydell wrote: > > On Tue, 7 Dec 2021 at 15:24, Peter Maydell wrote: > >> The bug is a bug in any case and we'll fix it, it's just a > >> question of whether it meets the bar to go into 6.2, which is > >> hopefully going to have its final RC tagged today. If this > >> patch had arrived a week ago then the bar would have been > >> lower and it would definitely have gone in. As it is I have > >> to weigh up the chances of this change causing a regression > >> for eg KVM running on emulated QEMU. > > > > Looking at the KVM source it doesn't ever set the LRENPIE > > bit (it doesn't even have a #define for it), which both > > explains why we didn't notice this bug before and also > > means we can be pretty certain we're not going to cause a > > regression for KVM at least if we fix it... > We are perfectly fine with this not going into 6.2. I thought about it a bit more, and realized that we could end up giving KVM spurious maintenance interrupts even though it doesn't set the LRENPIE bit, because the incorrect OR meant we'd send a maint irq whenever the EOIcount was nonzero. So we've put this fix in for 6.2. Thanks for the patch and the discussion. -- PMM