All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
	Samuel Thibault <samuel.thibault@ens-lyon.org>
Subject: Re: [Qemu-devel] [PATCH] curses: build with -std=gnu99
Date: Thu, 27 Oct 2016 16:04:53 +0100	[thread overview]
Message-ID: <CAFEAcA-2DwW_ozvF-0EhepNzgPuN=F_HwDfoy8V06M6KzAoRTw@mail.gmail.com> (raw)
In-Reply-To: <1477568774-4817-1-git-send-email-kraxel@redhat.com>

On 27 October 2016 at 12:46, Gerd Hoffmann <kraxel@redhat.com> wrote:
> ---
>  ui/Makefile.objs | 3 +++
>  1 file changed, 3 insertions(+)

Missing commit message and signed-off-by line...

> diff --git a/ui/Makefile.objs b/ui/Makefile.objs
> index dc936f1..62f4cf3 100644
> --- a/ui/Makefile.objs
> +++ b/ui/Makefile.objs
> @@ -17,6 +17,9 @@ common-obj-$(CONFIG_CURSES) += curses.o
>  common-obj-$(CONFIG_VNC) += $(vnc-obj-y)
>  common-obj-$(CONFIG_GTK) += gtk.o x_keymap.o
>
> +# needed to make gcc accept wide unicode chars without warning
> +curses.o-cflags := -std=gnu99
> +
>  ifeq ($(CONFIG_SDLABI),1.2)
>  sdl.mo-objs := sdl.o sdl_zoom.o
>  endif
> --
> 1.8.3.1

I'm not sure about this.

Do we really want gnu99 and not c99? Should we just enable
std=c99 for all source files, given that we already assume
C99 anyway?

It would also be helpful if the commit message quoted the
compiler warning that you get otherwise, so it's easier
to see why we're doing this.

thanks
-- PMM

  reply	other threads:[~2016-10-27 15:05 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-27 11:46 [Qemu-devel] [PATCH] curses: build with -std=gnu99 Gerd Hoffmann
2016-10-27 15:04 ` Peter Maydell [this message]
2016-10-27 15:55   ` Gerd Hoffmann
2016-10-27 15:58     ` Samuel Thibault
2016-10-27 16:14       ` Peter Maydell
2016-10-27 16:36         ` Samuel Thibault
2016-10-27 16:52           ` Peter Maydell
2016-10-27 17:02             ` Samuel Thibault
2016-10-28  6:51               ` Markus Armbruster
2016-10-28  7:40                 ` Samuel Thibault
2016-10-28  8:37                   ` Markus Armbruster
2016-10-28  9:45                     ` Gerd Hoffmann
     [not found] <mailman.13406.1477569887.22738.qemu-devel@nongnu.org>
2016-10-27 14:51 ` G 3
2016-10-27 15:07   ` Gerd Hoffmann
2016-10-27 15:12     ` G 3

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA-2DwW_ozvF-0EhepNzgPuN=F_HwDfoy8V06M6KzAoRTw@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=samuel.thibault@ens-lyon.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.