From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55835) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fXSUh-0002vc-5s for qemu-devel@nongnu.org; Mon, 25 Jun 2018 10:29:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fXSUg-0002ji-CP for qemu-devel@nongnu.org; Mon, 25 Jun 2018 10:29:27 -0400 Received: from mail-oi0-x241.google.com ([2607:f8b0:4003:c06::241]:41395) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fXSUf-0002jG-VC for qemu-devel@nongnu.org; Mon, 25 Jun 2018 10:29:26 -0400 Received: by mail-oi0-x241.google.com with SMTP id 21-v6so2005612oip.8 for ; Mon, 25 Jun 2018 07:29:25 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20180619093124.24011-8-luc.michel@greensocs.com> References: <20180619093124.24011-1-luc.michel@greensocs.com> <20180619093124.24011-8-luc.michel@greensocs.com> From: Peter Maydell Date: Mon, 25 Jun 2018 15:29:04 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" Subject: Re: [Qemu-devel] [PATCH v2 7/7] xlnx-zynqmp: Improve GIC wiring and MMIO mapping List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luc Michel Cc: QEMU Developers , qemu-arm , Sai Pavan Boddu , Edgar Iglesias , Mark Burton , Jan Kiszka On 19 June 2018 at 10:31, wrote: > From: Luc MICHEL > > This commit improve the way the GIC is realized and connected in the > ZynqMP SoC. The security extensions are enabled only if requested in the > machine state. The same goes for the virtualization extensions. > > All the GIC to APU CPU(s) IRQ lines are now connected, including FIQ, > vIRQ and vFIQ. The missing CPU to GIC timers IRQ connections are also > added (HYP and SEC timers). > > The GIC maintenance IRQs are back-wired to the correct GIC PPIs. > > Finally, the MMIO mappings are reworked to take into account the ZynqMP > specificities. the GIC (v)CPU interface is aliased 16 times: > * for the firsts 0x1000 bytes from 0xf9010000 to 0xf901f000 > * for the seconds 0x1000 bytes from 0xf9020000 to 0xf902f000 > Mappings of the virtual interface and virtual CPU interface are mapped > only when virtualization extensions are requested. The > XlnxZynqMPGICRegion struct has been enhanced to be able to catch all > this information. > > Signed-off-by: Luc MICHEL > --- > hw/arm/xlnx-zynqmp.c | 92 ++++++++++++++++++++++++++++++++---- > include/hw/arm/xlnx-zynqmp.h | 4 +- > 2 files changed, 86 insertions(+), 10 deletions(-) Nothing obviously wrong-looking in here; a review from one of the Xilinx folk would be good. thanks -- PMM