All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Laurent Vivier <laurent@vivier.eu>
Cc: Riku Voipio <riku.voipio@iki.fi>,
	QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 2/2] linux-user: don't swap NLMSG_DATA() fields
Date: Thu, 16 Jun 2016 22:09:18 +0100	[thread overview]
Message-ID: <CAFEAcA-5=Y2LvTYoS_baSYxynWTVWY4a0s6_G_HfH8cAjgBiwA@mail.gmail.com> (raw)
In-Reply-To: <1466103697-27279-3-git-send-email-laurent@vivier.eu>

On 16 June 2016 at 20:01, Laurent Vivier <laurent@vivier.eu> wrote:
> If the structure pointed by NLMSG_DATA() is bigger
> than the size of NLMSG_DATA(), don't swap its fields
> to avoid memory corruption.
>
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> ---

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

Can this actually happen in normal operation?

thanks
-- PMM

  reply	other threads:[~2016-06-16 21:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-16 19:01 [Qemu-devel] [PATCH 0/2] linux-user: netlink cleanup Laurent Vivier
2016-06-16 19:01 ` [Qemu-devel] [PATCH 1/2] linux-user: fd_trans_host_to_target_data() must process only received data Laurent Vivier
2016-06-16 21:05   ` Peter Maydell
2016-06-16 19:01 ` [Qemu-devel] [PATCH 2/2] linux-user: don't swap NLMSG_DATA() fields Laurent Vivier
2016-06-16 21:09   ` Peter Maydell [this message]
2016-06-16 22:09     ` Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA-5=Y2LvTYoS_baSYxynWTVWY4a0s6_G_HfH8cAjgBiwA@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=laurent@vivier.eu \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.