All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Joseph Myers <joseph@codesourcery.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Richard Henderson <rth@twiddle.net>,
	Eduardo Habkost <ehabkost@redhat.com>,
	QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH 1/5] target/i386: implement special cases for fxtract
Date: Thu, 25 Jun 2020 10:43:13 +0100	[thread overview]
Message-ID: <CAFEAcA-7ynHi2pDsPtSXWpG9PsfnCZzp4oXOodaccL5k3ggqcw@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2006232159560.6195@digraph.polyomino.org.uk>

On Tue, 23 Jun 2020 at 23:01, Joseph Myers <joseph@codesourcery.com> wrote:
>
> On Tue, 23 Jun 2020, Eduardo Habkost wrote:
>
> > > +        if (EXPD(temp) == 0) {
> > > +            int shift = clz64(temp.l.lower);
> > > +            temp.l.lower <<= shift;
> >
> > Coverity reports the following.  It looks like a false positive
> > because floatx80_is_zero() would be true if both EXPD(temp) and
> > temp.l.lower were zero, but maybe I'm missing something.
>
> Yes, that looks like a false positive to me.

Thanks; I've marked it as a fp in the coverity UI.

-- PMM


  reply	other threads:[~2020-06-25  9:44 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-07  0:42 [PATCH 0/5] target/i386: fxtract, fscale fixes Joseph Myers
2020-05-07  0:43 ` [PATCH 1/5] target/i386: implement special cases for fxtract Joseph Myers
2020-05-15  8:59   ` Alex Bennée
2020-06-23 21:42   ` Eduardo Habkost
2020-06-23 22:00     ` Joseph Myers
2020-06-25  9:43       ` Peter Maydell [this message]
2020-05-07  0:44 ` [PATCH 2/5] target/i386: fix fscale handling of signaling NaN Joseph Myers
2020-05-07  0:44 ` [PATCH 3/5] target/i386: fix fscale handling of invalid exponent encodings Joseph Myers
2020-05-07  0:45 ` [PATCH 4/5] target/i386: fix fscale handling of infinite exponents Joseph Myers
2020-05-07  0:46 ` [PATCH 5/5] target/i386: fix fscale handling of rounding precision Joseph Myers
2020-05-07  2:13 ` [PATCH 0/5] target/i386: fxtract, fscale fixes no-reply
2020-05-07 14:57   ` Joseph Myers
2020-05-08  3:42     ` Richard Henderson
2020-05-14 18:25 ` Ping " Joseph Myers
2020-05-14 23:02   ` Paolo Bonzini
2020-05-15  7:03 ` Philippe Mathieu-Daudé
2020-05-21 15:36 ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA-7ynHi2pDsPtSXWpG9PsfnCZzp4oXOodaccL5k3ggqcw@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=ehabkost@redhat.com \
    --cc=joseph@codesourcery.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.