From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot0-f194.google.com ([74.125.82.194]:42493 "EHLO mail-ot0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752736AbeDPMUu (ORCPT ); Mon, 16 Apr 2018 08:20:50 -0400 Received: by mail-ot0-f194.google.com with SMTP id h55-v6so17074629ote.9 for ; Mon, 16 Apr 2018 05:20:50 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1523541337-23919-1-git-send-email-geert+renesas@glider.be> References: <1523541337-23919-1-git-send-email-geert+renesas@glider.be> From: Peter Maydell Date: Mon, 16 Apr 2018 13:20:29 +0100 Message-ID: Subject: Re: [PATCH qemu v3] device_tree: Increase FDT_MAX_SIZE to 1 MiB To: Geert Uytterhoeven Cc: Peter Crosthwaite , Alexander Graf , QEMU Developers , Linux-Renesas , qemu-stable Content-Type: text/plain; charset="UTF-8" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: On 12 April 2018 at 14:55, Geert Uytterhoeven wrote: > It is not uncommon for a contemporary FDT to be larger than 64 KiB, > leading to failures loading the device tree from sysfs: > > qemu-system-aarch64: qemu_fdt_setprop: Couldn't set ...: FDT_ERR_NOSPACE > > Hence increase the limit to 1 MiB, like on PPC. > > For reference, the largest arm64 DTB created from the Linux sources is > ca. 75 KiB large (100 KiB when built with symbols/fixup support). > > Signed-off-by: Geert Uytterhoeven > --- > v3: > - Update example size figures, > > v2: > - Enlarge from 128 KiB to 1 MiB, as suggested by Peter Maydell. > --- > device_tree.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks; applied to target-arm.next for 2.13. I'll add cc:qemu-stable too. -- PMM From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37099) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f837r-0000ML-SH for qemu-devel@nongnu.org; Mon, 16 Apr 2018 08:20:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f837q-0005mw-St for qemu-devel@nongnu.org; Mon, 16 Apr 2018 08:20:51 -0400 Received: from mail-ot0-x242.google.com ([2607:f8b0:4003:c0f::242]:46545) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f837q-0005ma-KV for qemu-devel@nongnu.org; Mon, 16 Apr 2018 08:20:50 -0400 Received: by mail-ot0-x242.google.com with SMTP id v64-v6so17089929otb.13 for ; Mon, 16 Apr 2018 05:20:50 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1523541337-23919-1-git-send-email-geert+renesas@glider.be> References: <1523541337-23919-1-git-send-email-geert+renesas@glider.be> From: Peter Maydell Date: Mon, 16 Apr 2018 13:20:29 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" Subject: Re: [Qemu-devel] [PATCH qemu v3] device_tree: Increase FDT_MAX_SIZE to 1 MiB List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Geert Uytterhoeven Cc: Peter Crosthwaite , Alexander Graf , QEMU Developers , Linux-Renesas , qemu-stable On 12 April 2018 at 14:55, Geert Uytterhoeven wrote: > It is not uncommon for a contemporary FDT to be larger than 64 KiB, > leading to failures loading the device tree from sysfs: > > qemu-system-aarch64: qemu_fdt_setprop: Couldn't set ...: FDT_ERR_NOSPACE > > Hence increase the limit to 1 MiB, like on PPC. > > For reference, the largest arm64 DTB created from the Linux sources is > ca. 75 KiB large (100 KiB when built with symbols/fixup support). > > Signed-off-by: Geert Uytterhoeven > --- > v3: > - Update example size figures, > > v2: > - Enlarge from 128 KiB to 1 MiB, as suggested by Peter Maydell. > --- > device_tree.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks; applied to target-arm.next for 2.13. I'll add cc:qemu-stable too. -- PMM