From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66099C432BE for ; Thu, 26 Aug 2021 13:48:19 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 275E360F21 for ; Thu, 26 Aug 2021 13:48:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 275E360F21 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:47060 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mJFju-0002fu-CL for qemu-devel@archiver.kernel.org; Thu, 26 Aug 2021 09:48:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58512) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJFiy-0001Hf-UD for qemu-devel@nongnu.org; Thu, 26 Aug 2021 09:47:20 -0400 Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]:42929) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mJFix-0000jO-E8 for qemu-devel@nongnu.org; Thu, 26 Aug 2021 09:47:20 -0400 Received: by mail-ed1-x533.google.com with SMTP id z19so4740822edi.9 for ; Thu, 26 Aug 2021 06:47:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OVWfDsVaV5t53ZokKe7R9bEkloebB8cnpF/r/G9b7oc=; b=JaIDUOGkdrZtI7eEUYK9LMse3lEcj5KAOpfTQ+Qitf9dV3VeaM2Svcw2G4nrxJXsIu vDKTrJ93NcvG2Nj83hk4SHp/U8GtfyN8zf0O+BjDqJARj46YPIK9cSb6yvSw5UaUmpC0 RWjhoK7OdbEti7yn1y4ykrYTCzyPhrsK2kKEOCHQ+pppyeMHgtG//IJQCpZSPlhb/tXj xOirW/q8RfYhhvJDSnLAu05gzxqA2vTGzO//fiSKP+579Y9mpTGzr4jHxSF2ug8J98C6 SBxhlNiQKl2WhEsRVK10fYi1q7XFKDugB1UtorNNyrazVi8avcYEZ6tOZnSj3nLgHq8S 9eeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OVWfDsVaV5t53ZokKe7R9bEkloebB8cnpF/r/G9b7oc=; b=MKZB07TluRtpAgR77G7CY+x6SFfcftJvoAU4qXybJnb9B8xVHChJpH6HdPsDiG4JSR wV+c4HAdX1GyOZh2PMOXa7KtqT3L44rL3BvvcrBluOIfOoxvbzGfoBRasO7qnjSDFucm 1oxKISR1BXTChFtCYBs2XB1y3f0kZFhsboSpUk75T67TeedDe8Lmy7/q000wHV2tfMOm iNec4FIak2JoTCeUsNQ6J8rik4uwtE3U8uLazasyg8hS2txc28p/cI5WZ+E8QoseE8Ln oRtO9LvB8lWHHLA6GO6SR0SNf9dlTbhgAQp/4niOH/fospxJwcS9YNJhG00iTpDSnjWD qSxA== X-Gm-Message-State: AOAM531GKrXhwaP+FAGZkBZ0M46pRYzlF0cXNXobms6eSWfLPhNnusSM Y+5c/N9Hz6P9rnmC/B/r/pCTrJRqrNLW5nedM60wMQ== X-Google-Smtp-Source: ABdhPJyab+HhBlwXsSBfD8H51Mm6OLHVujSPeeDXRs2HDCbiwtN9sOkAeHazEO3sVSTzN3NB2U/v19bLfJaN6kXwpCs= X-Received: by 2002:aa7:cc0b:: with SMTP id q11mr4258175edt.251.1629985637414; Thu, 26 Aug 2021 06:47:17 -0700 (PDT) MIME-Version: 1.0 References: <20210821195958.41312-1-richard.henderson@linaro.org> <20210821195958.41312-7-richard.henderson@linaro.org> In-Reply-To: <20210821195958.41312-7-richard.henderson@linaro.org> From: Peter Maydell Date: Thu, 26 Aug 2021 14:46:30 +0100 Message-ID: Subject: Re: [PATCH v2 6/8] target/arm: Assert thumb pc is aligned To: Richard Henderson Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::533; envelope-from=peter.maydell@linaro.org; helo=mail-ed1-x533.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Sat, 21 Aug 2021 at 21:04, Richard Henderson wrote: > > Misaligned thumb PC is architecturally impossible. > Assert is better than proceeding, in case we've missed > something somewhere. > > Expand a comment about aligning the pc in gdbstub. > Fail an incoming migrate if a thumb pc is misaligned. > > Signed-off-by: Richard Henderson > --- Reviewed-by: Peter Maydell thanks -- PMM