[Qemu-devel] [PATCH for-2.9] configure: on Windows minimum glib version must be 2.30

[Qemu-devel] [PATCH for-2.9] configure: on Windows minimum glib version must be 2.30

[Peter Maydell]

In the 2.7 release we stated in the ChangeLog that the
minimum glib version for Windows hosts was 2.30, but we
didn't update configure to enforce this because we were
very close to the release at the point where we noticed
the issue, and it only affected building the test suite.
We then forgot that we needed to do it. Fix the omission.

(The reason for the 2.30 requirement is use of
g_dir_make_tmp() -- our fallback implementation uses
mkdtemp(), which isn't available on Windows.)

Reported-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 configure | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/configure b/configure
index 4b3b5cd..be4d326 100755
--- a/configure
+++ b/configure
@@ -3073,7 +3073,11 @@ fi
 ##########################################
 # glib support probe
 
-glib_req_ver=2.22
+if test "$mingw32" = yes; then
+    glib_req_ver=2.30
+else
+    glib_req_ver=2.22
+fi
 glib_modules=gthread-2.0
 if test "$modules" = yes; then
     glib_modules="$glib_modules gmodule-2.0"
-- 
2.7.4

Re: [Qemu-devel] [PATCH for-2.9] configure: on Windows minimum glib version must be 2.30

[Philippe Mathieu-Daudé]

On 04/03/2017 10:04 AM, Peter Maydell wrote:
> In the 2.7 release we stated in the ChangeLog that the
> minimum glib version for Windows hosts was 2.30, but we
> didn't update configure to enforce this because we were
> very close to the release at the point where we noticed
> the issue, and it only affected building the test suite.
> We then forgot that we needed to do it. Fix the omission.
>
> (The reason for the 2.30 requirement is use of
> g_dir_make_tmp() -- our fallback implementation uses
> mkdtemp(), which isn't available on Windows.)
>
> Reported-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> ---
>  configure | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 4b3b5cd..be4d326 100755
> --- a/configure
> +++ b/configure
> @@ -3073,7 +3073,11 @@ fi
>  ##########################################
>  # glib support probe
>
> -glib_req_ver=2.22
> +if test "$mingw32" = yes; then
> +    glib_req_ver=2.30
> +else
> +    glib_req_ver=2.22
> +fi
>  glib_modules=gthread-2.0
>  if test "$modules" = yes; then
>      glib_modules="$glib_modules gmodule-2.0"
>

Re: [Qemu-devel] [PATCH for-2.9] configure: on Windows minimum glib version must be 2.30

[Stefan Weil]

Am 03.04.2017 um 15:04 schrieb Peter Maydell:
> In the 2.7 release we stated in the ChangeLog that the
> minimum glib version for Windows hosts was 2.30, but we
> didn't update configure to enforce this because we were
> very close to the release at the point where we noticed
> the issue, and it only affected building the test suite.
> We then forgot that we needed to do it. Fix the omission.
>
> (The reason for the 2.30 requirement is use of
> g_dir_make_tmp() -- our fallback implementation uses
> mkdtemp(), which isn't available on Windows.)
>
> Reported-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  configure | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 4b3b5cd..be4d326 100755
> --- a/configure
> +++ b/configure
> @@ -3073,7 +3073,11 @@ fi
>  ##########################################
>  # glib support probe
>
> -glib_req_ver=2.22
> +if test "$mingw32" = yes; then
> +    glib_req_ver=2.30
> +else
> +    glib_req_ver=2.22
> +fi
>  glib_modules=gthread-2.0
>  if test "$modules" = yes; then
>      glib_modules="$glib_modules gmodule-2.0"


Reviewed-by: Stefan Weil <sw@weilnetz.de>

Thanks
Stefan

Re: [Qemu-devel] [PATCH for-2.9] configure: on Windows minimum glib version must be 2.30

[Peter Maydell]

On 3 April 2017 at 14:04, Peter Maydell <peter.maydell@linaro.org> wrote:
> In the 2.7 release we stated in the ChangeLog that the
> minimum glib version for Windows hosts was 2.30, but we
> didn't update configure to enforce this because we were
> very close to the release at the point where we noticed
> the issue, and it only affected building the test suite.
> We then forgot that we needed to do it. Fix the omission.
>
> (The reason for the 2.30 requirement is use of
> g_dir_make_tmp() -- our fallback implementation uses
> mkdtemp(), which isn't available on Windows.)
>
> Reported-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  configure | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 4b3b5cd..be4d326 100755
> --- a/configure
> +++ b/configure
> @@ -3073,7 +3073,11 @@ fi
>  ##########################################
>  # glib support probe
>
> -glib_req_ver=2.22
> +if test "$mingw32" = yes; then
> +    glib_req_ver=2.30
> +else
> +    glib_req_ver=2.22
> +fi
>  glib_modules=gthread-2.0
>  if test "$modules" = yes; then
>      glib_modules="$glib_modules gmodule-2.0"
> --
> 2.7.4

Applied to master, thanks.

-- PMM