All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Chen Gang <gang.chen.5i5j@gmail.com>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
	Markus Armbruster <armbru@redhat.com>,
	Anthony Liguori <aliguori@amazon.com>,
	QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] vl.c: use 'break' instead of 'continue' in configure_accelerator()
Date: Mon, 31 Mar 2014 14:01:21 +0100	[thread overview]
Message-ID: <CAFEAcA-GL7bnZ-Pkga9PzDq7DpwPf8Gx0Wezzkm_CCbSUB1W8A@mail.gmail.com> (raw)
In-Reply-To: <53396545.805@gmail.com>

On 31 March 2014 13:53, Chen Gang <gang.chen.5i5j@gmail.com> wrote:
> On 03/31/2014 08:38 PM, Markus Armbruster wrote:
>> Chen Gang <gang.chen.5i5j@gmail.com> writes:
>>
>>> Hello Maintainers:
>>>
>>> If it is necessary to send patch v2 by me, please let me know, I
>>> will/should send.
>>
>> Not a maintainer, but if you send a v2 with an improved commit message,
>> I'll R-by it, which can only help getting it merged.
>>
>
> I guess your meaning is "not quite necessary" (for me, minor useful
> patches almost like spam). So if sending patch v2 is really required,
> please let me know, thanks.

Basically, asking a maintainer to make changes to a patch
as they apply it is asking them to do extra work beyond
what they would normally do. Sometimes people will agree
to do this, but in general it's better just to send a fixed
version of the patch yourself.

(I've cc'd qemu-trivial since that's probably the best tree
to take this patch.)

thanks
-- PMM

  reply	other threads:[~2014-03-31 13:02 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-27  1:16 [Qemu-devel] [PATCH] vl.c: use 'break' instead of 'continue' in configure_accelerator() Chen Gang
2014-03-27  7:55 ` Marcel Apfelbaum
2014-03-27  9:54   ` Chen Gang
2014-03-27  8:59 ` Markus Armbruster
2014-03-27 10:01   ` Chen Gang
2014-03-30 14:44     ` Chen Gang
2014-03-31 12:38       ` Markus Armbruster
2014-03-31 12:53         ` Chen Gang
2014-03-31 13:01           ` Peter Maydell [this message]
2014-03-31 13:12             ` Chen Gang
2014-03-31 13:16               ` Peter Maydell
2014-03-31 13:26                 ` Chen Gang
2014-03-31 13:33                   ` Peter Maydell
2014-03-31 23:50                     ` Chen Gang
2014-04-04  9:39                     ` [Qemu-devel] [PATCH-trivial v2] vl: Report accelerator not supported for target more nicely Chen Gang
2014-04-04 10:57                       ` Markus Armbruster
2014-04-06 12:30                         ` Chen Gang
2014-04-06  6:32                       ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2014-04-06 12:32                         ` Chen Gang
2014-04-08 12:00                           ` [Qemu-devel] [PATCH trivial 0/3] vl: simplify code for main() and get_boot_device() Chen Gang
2014-04-08 12:01                             ` [Qemu-devel] [PATCH trivial 1/3] vl: remove useless 'continue' Chen Gang
2014-04-08 12:02                               ` [Qemu-devel] [PATCH trivial 2/3] vl: remove redundant local variable 'res' Chen Gang
2014-04-08 12:05                                 ` [Qemu-devel] [PATCH trivial 3/3] vl: remove local variable 'args' in the middle of code block Chen Gang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA-GL7bnZ-Pkga9PzDq7DpwPf8Gx0Wezzkm_CCbSUB1W8A@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=aliguori@amazon.com \
    --cc=armbru@redhat.com \
    --cc=gang.chen.5i5j@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.