From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36121) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wiky8-0000Dz-6P for qemu-devel@nongnu.org; Fri, 09 May 2014 09:36:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wiky3-0003au-0i for qemu-devel@nongnu.org; Fri, 09 May 2014 09:36:08 -0400 Received: from mail-la0-f49.google.com ([209.85.215.49]:39782) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wiky2-0003ao-Pq for qemu-devel@nongnu.org; Fri, 09 May 2014 09:36:02 -0400 Received: by mail-la0-f49.google.com with SMTP id pv20so208436lab.22 for ; Fri, 09 May 2014 06:36:01 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1398713302-29657-13-git-send-email-rth@twiddle.net> References: <1398713302-29657-1-git-send-email-rth@twiddle.net> <1398713302-29657-13-git-send-email-rth@twiddle.net> From: Peter Maydell Date: Fri, 9 May 2014 14:35:41 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH v3 12/16] tcg-s390: Define TCG_TARGET_INSN_UNIT_SIZE List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: QEMU Developers On 28 April 2014 20:28, Richard Henderson wrote: > And use tcg pointer differencing functions as appropriate. > > Signed-off-by: Richard Henderson > --- > tcg/s390/tcg-target.c | 91 ++++++++++++++++++++++++--------------------------- > tcg/s390/tcg-target.h | 2 ++ > 2 files changed, 45 insertions(+), 48 deletions(-) > > diff --git a/tcg/s390/tcg-target.c b/tcg/s390/tcg-target.c > index 1d912a7..ae1be1c 100644 > --- a/tcg/s390/tcg-target.c > +++ b/tcg/s390/tcg-target.c > @@ -320,7 +320,7 @@ static const uint8_t tcg_cond_to_ltr_cond[] = { > #ifdef CONFIG_SOFTMMU > /* helper signature: helper_ld_mmu(CPUState *env, target_ulong addr, > int mmu_idx) */ > -static const void * const qemu_ld_helpers[4] = { > +static void * const qemu_ld_helpers[4] = { > helper_ldb_mmu, > helper_ldw_mmu, > helper_ldl_mmu, > @@ -329,7 +329,7 @@ static const void * const qemu_ld_helpers[4] = { > > /* helper signature: helper_st_mmu(CPUState *env, target_ulong addr, > uintxx_t val, int mmu_idx) */ > -static const void * const qemu_st_helpers[4] = { > +static void * const qemu_st_helpers[4] = { > helper_stb_mmu, > helper_stw_mmu, > helper_stl_mmu, Why do these lose the 'const' ? Patch looks ok otherwise from a quick scan. thanks -- PMM