From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50066)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1begbW-0003Kw-1P
	for qemu-devel@nongnu.org; Tue, 30 Aug 2016 06:49:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1begbU-0005Qo-V9
	for qemu-devel@nongnu.org; Tue, 30 Aug 2016 06:49:18 -0400
Received: from mail-ua0-x22c.google.com ([2607:f8b0:400c:c08::22c]:33822)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1begbU-0005Qi-Qw
	for qemu-devel@nongnu.org; Tue, 30 Aug 2016 06:49:16 -0400
Received: by mail-ua0-x22c.google.com with SMTP id k90so25460887uak.1
	for <qemu-devel@nongnu.org>; Tue, 30 Aug 2016 03:49:16 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1c6d5569-ea7c-04ad-ad35-e48903c9b0d6@kamp.de>
References: <1471365032-18096-1-git-send-email-berrange@redhat.com>
	<1c6d5569-ea7c-04ad-ad35-e48903c9b0d6@kamp.de>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Tue, 30 Aug 2016 11:48:55 +0100
Message-ID: <CAFEAcA-JCSn-6RJ8Qwk9SOC=X-=UrKP5Ca3uu+5J1y=5R9MBcQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [Qemu-stable] [PATCH v2 for 2.7] ui: fix refresh
 of VNC server surface
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Lieven <pl@kamp.de>
Cc: "Daniel P. Berrange" <berrange@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>, Gerd Hoffmann <kraxel@redhat.com>, qemu-stable <qemu-stable@nongnu.org>

On 29 August 2016 at 14:44, Peter Lieven <pl@kamp.de> wrote:
> Am 16.08.2016 um 18:30 schrieb Daniel P. Berrange:

>> To fix this we must explicitly mark the entire guest desktop
>> as dirty after re-creating the server surface. Move this
>> logic into vnc_update_server_surface() so it is guaranteed
>> to be call in all code paths that re-create the surface
>> instead of only in vnc_dpy_switch()
>>
>> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>

> I can confirm this issue now. Its only visible if the VNC client does not
> send a SET_PIXEL_FORMAT message.
> Which my client does and this masked the issue for me. The set pixel format
> routine invalidates
> the whole display which results in a vnc_dpy_switch which masks the guest fb
> dirty. Why this invalidation
> takes place I do not understand, but this can be sorted out lated.
>
> For this patch:
> Tested-by: Peter Lieven <pl@kamp.de>
> Reviewed-by: Peter Lieven <pl@kamp.de>

Applied to master for 2.7, thanks.

-- PMM