All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: "Richard W.M. Jones" <rjones@redhat.com>, Alexander Graf <agraf@suse.de>
Cc: Michael Matz <matz@suse.de>, QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] arm64: Set source for ret instruction correctly.
Date: Mon, 23 Dec 2013 22:17:15 +0000	[thread overview]
Message-ID: <CAFEAcA-MGw+o7KV=6BQwFTkvw3-wCk5ObcgQY3JqYKTpm-C-iw@mail.gmail.com> (raw)
In-Reply-To: <1387836029-17163-1-git-send-email-rjones@redhat.com>

On 23 December 2013 22:00, Richard W.M. Jones <rjones@redhat.com> wrote:
> From: "Richard W.M. Jones" <rjones@redhat.com>
>
> Fixes https://bugs.launchpad.net/qemu/+bug/1263747
>
> Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
> Tested-by: Richard W.M. Jones <rjones@redhat.com>
> ---

I'm guessing this is against the SuSE tree? Probably best to
say so specifically, because this code is different in mainline.
CC'ing Alex who might also care about SuSE tree fixes.


>  target-arm/translate-a64.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c
> index 36ebb0f..29454b0 100644
> --- a/target-arm/translate-a64.c
> +++ b/target-arm/translate-a64.c
> @@ -273,7 +273,6 @@ static void handle_br(DisasContext *s, uint32_t insn)
>          tcg_gen_movi_i64(cpu_reg(30), s->pc);
>          break;
>      case 2: /* RET */
> -        source = 30;
>          break;
>      case 3:
>          unallocated_encoding(s);
> --
> 1.8.3.1
>

FWIW mainline's handling of this insn doesn't have this bug.

thanks
-- PMM

  reply	other threads:[~2013-12-23 22:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-23 22:00 [Qemu-devel] [PATCH] arm64: Set source for ret instruction correctly Richard W.M. Jones
2013-12-23 22:17 ` Peter Maydell [this message]
2013-12-24  8:45   ` Richard W.M. Jones
2013-12-24 10:33     ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA-MGw+o7KV=6BQwFTkvw3-wCk5ObcgQY3JqYKTpm-C-iw@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=agraf@suse.de \
    --cc=matz@suse.de \
    --cc=qemu-devel@nongnu.org \
    --cc=rjones@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.