From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39811)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1YGCIs-0004l0-Kz
	for qemu-devel@nongnu.org; Tue, 27 Jan 2015 15:00:03 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1YGCIn-00070P-Gn
	for qemu-devel@nongnu.org; Tue, 27 Jan 2015 15:00:02 -0500
Received: from mail-la0-f41.google.com ([209.85.215.41]:56174)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1YGCIn-00070F-Al
	for qemu-devel@nongnu.org; Tue, 27 Jan 2015 14:59:57 -0500
Received: by mail-la0-f41.google.com with SMTP id gm9so15354482lab.0
	for <qemu-devel@nongnu.org>; Tue, 27 Jan 2015 11:59:56 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <CAOgzsHUN9=sm5MFxzJb9hsW-+m1VCN0RBjrrSVzLCp60u-7v5g@mail.gmail.com>
References: <1422037228-5363-1-git-send-email-peter.maydell@linaro.org>
	<1422037228-5363-10-git-send-email-peter.maydell@linaro.org>
	<CAOgzsHVyAuB=oNWd2e1k-5MQio=oAVNj3=LtPXxsigDjYkmtcw@mail.gmail.com>
	<CAFEAcA9gf5Y7swSZgjBgp_o=nk=7PtvNG0Pd+0baM3QGLQ7ecA@mail.gmail.com>
	<CAOgzsHUN9=sm5MFxzJb9hsW-+m1VCN0RBjrrSVzLCp60u-7v5g@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Tue, 27 Jan 2015 19:59:36 +0000
Message-ID: <CAFEAcA-P+dLqx4hg=E1mwg0X14+m6iySGvLQ9HZ_fb6qOr-NKA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH 09/11] target-arm: Use mmu_idx in
	get_phys_addr()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Greg Bellows <greg.bellows@linaro.org>
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Andrew Jones <drjones@redhat.com>, =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>, QEMU Developers <qemu-devel@nongnu.org>, Patch Tracking <patches@linaro.org>

On 27 January 2015 at 19:49, Greg Bellows <greg.bellows@linaro.org> wrote:
> On Tue, Jan 27, 2015 at 12:12 PM, Peter Maydell <peter.maydell@linaro.org>
> wrote:
>> g_assert_not_reached(),  but it didn't seem worth cluttering
>> the switch with a bunch of extra labels just to assert that
>> they weren't reachable.
>>
>
> I see how it could clutter things, but given that the routine is generic we
> probably should just like we do in regime_el().

Not a big deal, so I'll add them, but the routine isn't generic --
it's purely a local utility routine for the benefit of the
get_phys_addr family of functions and not intended to be called
from elsewhere.

-- PMM