Re: [Qemu-devel] [PATCH 0/2] ARM virt: Silence dtc warnings

[Peter Maydell <peter.maydell@linaro.org>]

On 9 June 2018 at 15:23, Eric Auger <eric.auger@redhat.com> wrote:
> When running dtc on the guest /proc/device-tree, we get the
> following warnings: "Warning (unit_address_vs_reg): Node <name>
> has a reg or ranges property, but no unit name", with name:
> /intc, /intc/its, /intc/v2m, /memory.
>
> This series removes those warnings by adding the unit address to
> the corresponding node names.

Thanks for this patchset -- Marc Z reported this ages ago
but I never got round to looking at it.

Patch 1 looks fine, but patch 2 changing the "/memory" node
handling I'm less happy with. Currently we're consistent: we
assume that the memory node must always be called "/memory",
and we look for an existing node that way and create our own
with that name. If in fact memory nodes might not be named
"/memory" then we need to look for any preexisting "/memory@*" node,
not just "/memory", don't we?

thanks
-- PMM