From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DA28C432BE for ; Mon, 30 Aug 2021 20:17:51 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 835A06101B for ; Mon, 30 Aug 2021 20:17:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 835A06101B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:52544 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mKnj3-0005FC-16 for qemu-devel@archiver.kernel.org; Mon, 30 Aug 2021 16:17:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35174) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mKnge-0003A4-QA for qemu-devel@nongnu.org; Mon, 30 Aug 2021 16:15:20 -0400 Received: from mail-ej1-x632.google.com ([2a00:1450:4864:20::632]:34732) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mKngc-0003Q2-Au for qemu-devel@nongnu.org; Mon, 30 Aug 2021 16:15:20 -0400 Received: by mail-ej1-x632.google.com with SMTP id u3so33643421ejz.1 for ; Mon, 30 Aug 2021 13:15:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gZHxqII6pE72vP1yX9i41mIgsKVp3Raa/v4NDJVfcxM=; b=qQ7la5ngyYE+rrBSYfuSlulO+sgiNAUuIrjrViyvC1IUDhVF7ffqeMrZLQFZsWJ4FW A2SoXkYmzh1qXSAfGjsefzEBfyKZJQNeQAO/S4K8+SVDh4/iIn3S7w5YSRVPzvKk8zu1 IyQlAyLC7gifBvw5Z4j/VeOuWfcmNIqnp9uiW5ROd1FAREBKKNsFWcr+pGYqAHpr/3Yk 8pbVYSCnlA1ypcLUb32eH8oS9TSaFOaHqc/JpwemcjJIVsJYIjX8k8KaGS+fW8mWMbQ7 PTUSa5Xx2aK/YgypCgb2MkSwCCg2/F/jF9BhlxQ45wXIlwFftcEBhnZmY7EAW8U8mXTn i4Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gZHxqII6pE72vP1yX9i41mIgsKVp3Raa/v4NDJVfcxM=; b=cpDLpQG/cLC7lcCFu6U42c7qIMjIn6kxYoLQIR71BLQUI6YmPiJV1seJ548Y3LdGJj QjTJ0TE5AlTHLvYlIX0fwB8OXh2uqSpcmgFDOHVzaU3ipkDzLF63GMQm/LmTGbOSIdDY kcM33lH7EEen9KQVcUBqh7NlQ8113UDCSoejCxRIVuguHhX83tW5aNhhaPSM8XCrDTMz Djkatma6XVOf9iDYMTlVPBqoeSVCXItW2I1pb5zCvS9rBlnoTFdDpbkWWOfMKufRbooR 2qFDaCJAyGTFfPrMEZxkVkDLaoz44xjCUs+OlVbmjGndBeRNT55aZnISfilPn6PkgFfP xfsQ== X-Gm-Message-State: AOAM531ifj5WX4ZYPj+GV/vREYaApsF/JTr2YAB0KG4Hv6YKRSRgVqv3 a5p898WsyUYLmrwMY59m1XNSsnDChR3FXg9v/M62xQ== X-Google-Smtp-Source: ABdhPJxNbYcf3zDhoAE+d1zSPUTffTrsWA8fm1Cr92qAvtCcsPeoJ4lVHzWxUX7F6+54iN1FPzT7Q4b7GYt9LJR1IZ0= X-Received: by 2002:a17:907:923:: with SMTP id au3mr24792012ejc.482.1630354516646; Mon, 30 Aug 2021 13:15:16 -0700 (PDT) MIME-Version: 1.0 References: <20210805193950.514357-1-johannes.stoelp@gmail.com> <20210830154708.ah27fh34q5dgg3le@redhat.com> In-Reply-To: From: Peter Maydell Date: Mon, 30 Aug 2021 21:14:28 +0100 Message-ID: Subject: Re: [PATCH v0] kvm: unsigned datatype in ioctl wrapper To: Johannes S Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::632; envelope-from=peter.maydell@linaro.org; helo=mail-ej1-x632.google.com X-Spam_score_int: -1 X-Spam_score: -0.2 X-Spam_bar: / X-Spam_report: (-0.2 / 5.0 requ) DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Trivial , =?UTF-8?Q?Johannes_St=C3=B6lp?= , Eric Blake , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 30 Aug 2021 at 20:37, Johannes S wrote: > In my opinion we should use 'unsigned' data types here for the ioctl > request in the ioctl wrappers or would you prefer to keep the ioctl > wrapper definition as is today? What is you opinion? I think I would vote for following the type used by the ioctl() function as declared in the headers for both Linux and the BSDs, and using 'unsigned long'. (We should change KVMState::irq_set_ioctl too, to match.) -- PMM