From: Peter Maydell <peter.maydell@linaro.org>
To: Michael Rolnik <mrolnik@gmail.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v17 6/9] target-avr: adding helpers for IN, OUT, SLEEP, WBR & unsupported instructions
Date: Thu, 18 Aug 2016 19:16:36 +0100 [thread overview]
Message-ID: <CAFEAcA-QkC6K4aRuno+uCr-aaP9mcg9ZF1aUEN6YNMGJki+vvw@mail.gmail.com> (raw)
In-Reply-To: <1471522070-77598-7-git-send-email-mrolnik@gmail.com>
On 18 August 2016 at 13:07, Michael Rolnik <mrolnik@gmail.com> wrote:
> Signed-off-by: Michael Rolnik <mrolnik@gmail.com>
> @@ -79,11 +80,11 @@ void avr_cpu_do_interrupt(CPUState *cs)
>
> if (avr_feature(env, AVR_FEATURE_3_BYTE_PC)) {
> cpu_stb_data(env, env->sp--, (ret & 0x0000ff));
> - cpu_stb_data(env, env->sp--, (ret & 0x00ff00) >> 8);
> + cpu_stb_data(env, env->sp--, (ret & 0x00ff00) >> 8);
> cpu_stb_data(env, env->sp--, (ret & 0xff0000) >> 16);
> } else if (avr_feature(env, AVR_FEATURE_2_BYTE_PC)) {
> cpu_stb_data(env, env->sp--, (ret & 0x0000ff));
> - cpu_stb_data(env, env->sp--, (ret & 0x00ff00) >> 8);
> + cpu_stb_data(env, env->sp--, (ret & 0x00ff00) >> 8);
> } else {
> cpu_stb_data(env, env->sp--, (ret & 0x0000ff));
> }
These whitespace changes should be squashed into the commit where the
code was added.
thanks
-- PMM
next prev parent reply other threads:[~2016-08-18 18:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-18 12:07 [Qemu-devel] [PATCH v17 0/9] 8bit AVR cores Michael Rolnik
2016-08-18 12:07 ` [Qemu-devel] [PATCH v17 1/9] target-avr: AVR cores support is added Michael Rolnik
2016-08-18 18:13 ` Peter Maydell
2016-08-18 12:07 ` [Qemu-devel] [PATCH v17 2/9] target-avr: adding AVR CPU features/flavors Michael Rolnik
2016-08-18 18:14 ` Peter Maydell
2016-08-18 12:07 ` [Qemu-devel] [PATCH v17 3/9] target-avr: adding a sample AVR board Michael Rolnik
2016-08-18 18:14 ` Peter Maydell
2016-08-18 12:07 ` [Qemu-devel] [PATCH v17 4/9] target-avr: adding instructions encodings Michael Rolnik
2016-08-18 12:07 ` [Qemu-devel] [PATCH v17 5/9] target-avr: adding AVR interrupt handling Michael Rolnik
2016-08-18 18:32 ` Peter Maydell
2016-08-18 12:07 ` [Qemu-devel] [PATCH v17 6/9] target-avr: adding helpers for IN, OUT, SLEEP, WBR & unsupported instructions Michael Rolnik
2016-08-18 18:16 ` Peter Maydell [this message]
2016-08-18 12:07 ` [Qemu-devel] [PATCH v17 7/9] target-avr: adding instruction translation Michael Rolnik
2016-08-18 12:07 ` [Qemu-devel] [PATCH v17 8/9] target-avr: instruction decoder generator Michael Rolnik
2016-08-18 12:07 ` [Qemu-devel] [PATCH v17 9/9] target-avr: adding instruction decoder Michael Rolnik
2016-08-18 12:26 ` [Qemu-devel] [PATCH v17 0/9] 8bit AVR cores no-reply
2016-08-18 18:34 ` Peter Maydell
2016-09-05 10:52 ` Michael Rolnik
2016-09-16 6:45 ` Michael Rolnik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA-QkC6K4aRuno+uCr-aaP9mcg9ZF1aUEN6YNMGJki+vvw@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=mrolnik@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.