From: Peter Maydell <peter.maydell@linaro.org>
To: Shannon Zhao <shannon.zhaosl@gmail.com>
Cc: Shannon Zhao <zhaoshenglong@huawei.com>,
qemu-arm <qemu-arm@nongnu.org>,
Eric Auger <eric.auger@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
qemu-stable <qemu-stable@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v5 2/2] arm_gicv3_kvm: kvm_dist_get/put: skip the registers banked by GICR
Date: Thu, 31 May 2018 15:56:30 +0100 [thread overview]
Message-ID: <CAFEAcA-R6N3Umg6=TzQrwoCw8VAL7VT7NTzLN4TnKoPBP4jRBQ@mail.gmail.com> (raw)
In-Reply-To: <CAOMwq8-H+iZ1L996G4jdky__zstwFo6x0qTucqLRstuXhs1CEA@mail.gmail.com>
On 31 May 2018 at 15:36, Shannon Zhao <shannon.zhaosl@gmail.com> wrote:
>
>
> 2018-05-31 21:50 GMT+08:00 Peter Maydell <peter.maydell@linaro.org>:
>> Shouldn't we be adding the same thing to clroffset that we add to offset ?
>>
>> Yeah, right. It should like this
>
> clroffset += (GIC_INTERNAL * 1) / 8;
>
> I don't remember why I didn't write this way. Anyway, Could you please fix
> this when you apply this patch or I send a new version?
It's probably easiest if you resend; you have Eric's comment
typos to fix too.
thanks
-- PMM
prev parent reply other threads:[~2018-05-31 14:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-31 3:15 [Qemu-devel] [PATCH v5 0/2] Fix ARM KVM GICv3 get/put data shift bug Shannon Zhao
2018-05-31 3:15 ` [Qemu-devel] [PATCH v5 1/2] arm_gicv3_kvm: kvm_dist_get/put_priority: skip the registers banked by GICR_IPRIORITYR Shannon Zhao
2018-05-31 11:01 ` Auger Eric
2018-06-11 8:32 ` Shannon Zhao
2018-06-11 13:08 ` Peter Maydell
2018-05-31 3:15 ` [Qemu-devel] [PATCH v5 2/2] arm_gicv3_kvm: kvm_dist_get/put: skip the registers banked by GICR Shannon Zhao
2018-05-31 11:32 ` Auger Eric
2018-05-31 13:50 ` Peter Maydell
2018-05-31 14:36 ` Shannon Zhao
2018-05-31 14:56 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA-R6N3Umg6=TzQrwoCw8VAL7VT7NTzLN4TnKoPBP4jRBQ@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=eric.auger@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=shannon.zhaosl@gmail.com \
--cc=zhaoshenglong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.