From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33907) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sv7NX-000134-KS for qemu-devel@nongnu.org; Sat, 28 Jul 2012 09:48:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sv7NW-0005Ky-G9 for qemu-devel@nongnu.org; Sat, 28 Jul 2012 09:48:23 -0400 Received: from mail-gg0-f173.google.com ([209.85.161.173]:36699) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sv7NW-0005Kt-Be for qemu-devel@nongnu.org; Sat, 28 Jul 2012 09:48:22 -0400 Received: by ggnp1 with SMTP id p1so3839546ggn.4 for ; Sat, 28 Jul 2012 06:48:21 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1342620628-12751-1-git-send-email-peter.maydell@linaro.org> <1342620628-12751-12-git-send-email-peter.maydell@linaro.org> Date: Sat, 28 Jul 2012 14:48:21 +0100 Message-ID: From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH 11/11] configure: Check for -Werror causing failures when compiling tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: Stefan Weil , qemu-devel@nongnu.org, patches@linaro.org On 28 July 2012 13:31, Blue Swirl wrote: > I'm getting this error, probably because now Valgrind support is enabled: > CC coroutine-ucontext.o > cc1: warnings being treated as errors > /src/qemu/coroutine-ucontext.c:204: error: unknown option after > '#pragma GCC diagnostic' kind > /src/qemu/coroutine-ucontext.c:209: error: unknown option after > '#pragma GCC diagnostic' kind > > Maybe the compiler does not understand this pragma and Valgrind check > should also fail in that case. Yeah, I think this is one of the few tests which want to explicitly check "is this construct going to provoke a compiler warning" -- fix is for that test to explictly put -Werror in the cflags in the compile_prog line. -- PMM