From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56938)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1ZgUlb-0001jT-OJ
	for qemu-devel@nongnu.org; Mon, 28 Sep 2015 05:30:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1ZgUlV-0002qP-UJ
	for qemu-devel@nongnu.org; Mon, 28 Sep 2015 05:30:39 -0400
Received: from mail-yk0-f179.google.com ([209.85.160.179]:34524)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1ZgUlV-0002qA-Pk
	for qemu-devel@nongnu.org; Mon, 28 Sep 2015 05:30:33 -0400
Received: by ykdg206 with SMTP id g206so169009778ykd.1
	for <qemu-devel@nongnu.org>; Mon, 28 Sep 2015 02:30:33 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <560905C5.2030209@redhat.com>
References: <1443121042-3409-1-git-send-email-armbru@redhat.com>
	<1443121042-3409-7-git-send-email-armbru@redhat.com>
	<56054E5E.3090005@redhat.com>
	<87y4fu1t3j.fsf@blackfin.pond.sub.org> <560590A6.3030408@redhat.com>
	<87io6vm08l.fsf@blackfin.pond.sub.org> <560905C5.2030209@redhat.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Mon, 28 Sep 2015 10:30:13 +0100
Message-ID: <CAFEAcA-VB8P16yKZjymRc4oP=tZgSpps-y9mFzFBLn2m92sMXA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH v3 6/7] qdev: Protect
 device-list-properties against broken devices
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Thomas Huth <thuth@redhat.com>
Cc: Alexander Graf <agraf@suse.de>, Eduardo Habkost <ehabkost@redhat.com>, Peter Crosthwaite <crosthwaite.peter@gmail.com>, Markus Armbruster <armbru@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>, qemu-stable <qemu-stable@nongnu.org>, Christian Borntraeger <borntraeger@de.ibm.com>, "qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>, Antony Pavlov <antonynpavlov@gmail.com>, Stefan Hajnoczi <stefanha@redhat.com>, Cornelia Huck <cornelia.huck@de.ibm.com>, Paolo Bonzini <pbonzini@redhat.com>, Alistair Francis <alistair.francis@xilinx.com>, =?UTF-8?Q?Andreas_F=C3=A4rber?= <afaerber@suse.de>, Li Guang <lig.fnst@cn.fujitsu.com>, Richard Henderson <rth@twiddle.net>

On 28 September 2015 at 10:17, Thomas Huth <thuth@redhat.com> wrote:
> By the way, there are some more spots like this in the code, e.g. in
> pxa2xx_fir_instance_init() in hw/arm/pxa2xx.c ...

That's an oversight from when it was converted to qdev, I think,
and could be fixed.

-- PMM