From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DD50C54E4A for ; Tue, 12 May 2020 13:54:56 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D7B38206CC for ; Tue, 12 May 2020 13:54:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="TdsDHFub" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D7B38206CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54068 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jYVN1-0008Kj-1m for qemu-devel@archiver.kernel.org; Tue, 12 May 2020 09:54:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51020) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jYVKh-0004dB-Tl for qemu-devel@nongnu.org; Tue, 12 May 2020 09:52:31 -0400 Received: from mail-oo1-xc41.google.com ([2607:f8b0:4864:20::c41]:33658) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jYVKf-0005UF-HI for qemu-devel@nongnu.org; Tue, 12 May 2020 09:52:31 -0400 Received: by mail-oo1-xc41.google.com with SMTP id b3so1025198oob.0 for ; Tue, 12 May 2020 06:52:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=p8dn1iXcWkPSv7fvGUaQuzirip7wY+d8CA4bLUsNgxo=; b=TdsDHFuba5pDBPaCsP0Wp5vSBQTTpXhpIUSHdmwCmhjU/pSny1nErKgZVo+xNLuZwN GyIdB6PtQvkkSUClDcgyZR/oQvLNZJ+w0bwnDwQQ1KdF81zkSKLeVyvrmHN4muF3PTxz Ytbvnmq46qcV5DWunhcrahYfoqYJqqxc66hb4JnR/vjxGRG1LRLdNDLJuMphg9Z2EHIf aklIpg+19PGjcIyFiejAKwOxfM7HwUGttetlEoerxrXYrp5lsx/bDOzy8nvLFKrfncwO Bb5e8LDx/TmVowwg+XZt+PGBMAH6fRlrS/XzE4YZCFX6xsh2G/3M+PK2r5IgHQrqW+ln nfQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=p8dn1iXcWkPSv7fvGUaQuzirip7wY+d8CA4bLUsNgxo=; b=RllBbErSRTzNWlx3qvSTjRqLLKZq/DLTUKYS+vsp/yVGBe2npx7maDkC3551K22aU6 OGVg0ITY9/403UZPgDva2fPXHxHI15kUPJ4XuYESBRsOW3ljpRmz97HU9y6PmPC7URZ4 o7cDtToOKUVeAtiiNIw81XiQEzkE1M/Uk3OMBLolq2f2o14opDWJICsb2LeRI2bYB6Te pOydT587oMji46n18WQ89+3OVeLQS7f6CBxyL5O0INuilyyttrYLtOPRNcbnL23a43JJ P968A8dzeKmFo1/BEjbNBjlldPA3QnsPAb5ZBRvaFBHYwjRoRBSZbaR6kZSTXrn4HEIf 4wzQ== X-Gm-Message-State: AGi0PuawmbO6Ir5VEEdWa/SntOFuVAtZEn2RhyLFG3cHeG6g12hFiTiS 5tVTFPGMJN4SvFTbogLPbbTP/mmDeJqf7an4Jw1sY6SBix4= X-Google-Smtp-Source: APiQypJ0+yHDRCD8r0xeNTAQT/b1ntTnu0pFYP5HYyJ9g4HgMFcTV5JKGjwlWyjqBFNlnqOVSpvQ9WNS1ZrzDRIC3ng= X-Received: by 2002:a4a:3556:: with SMTP id w22mr12224500oog.20.1589291548169; Tue, 12 May 2020 06:52:28 -0700 (PDT) MIME-Version: 1.0 References: <20200508152200.6547-1-richard.henderson@linaro.org> <20200508152200.6547-4-richard.henderson@linaro.org> In-Reply-To: <20200508152200.6547-4-richard.henderson@linaro.org> From: Peter Maydell Date: Tue, 12 May 2020 14:52:16 +0100 Message-ID: Subject: Re: [PATCH v3 03/16] target/arm: Create gen_gvec_{sri,sli} To: Richard Henderson Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::c41; envelope-from=peter.maydell@linaro.org; helo=mail-oo1-xc41.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 8 May 2020 at 16:22, Richard Henderson wrote: > > The functions eliminate duplication of the special cases for > this operation. They match up with the GVecGen2iFn typedef. > > Add out-of-line helpers. We got away with only having inline > expanders because the neon vector size is only 16 bytes, and > we know that the inline expansion will always succeed. > When we reuse this for SVE, tcg-gvec-op may decide to use an > out-of-line helper due to longer vector lengths. > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM