From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92B04C2D0F1 for ; Tue, 31 Mar 2020 17:05:02 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5D8FE20848 for ; Tue, 31 Mar 2020 17:05:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SLv0dQ7u" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D8FE20848 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41914 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJKJx-0003ds-I4 for qemu-devel@archiver.kernel.org; Tue, 31 Mar 2020 13:05:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47036) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJKIm-0002Og-L9 for qemu-devel@nongnu.org; Tue, 31 Mar 2020 13:03:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jJKIk-0008WQ-EO for qemu-devel@nongnu.org; Tue, 31 Mar 2020 13:03:48 -0400 Received: from mail-oi1-x236.google.com ([2607:f8b0:4864:20::236]:36107) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jJKIj-0008VL-Cz for qemu-devel@nongnu.org; Tue, 31 Mar 2020 13:03:45 -0400 Received: by mail-oi1-x236.google.com with SMTP id k18so19574505oib.3 for ; Tue, 31 Mar 2020 10:03:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=9blV1H9Js4on1Ru4pm7hErJIva7kNEymOz2IOkz5vus=; b=SLv0dQ7u1fEVRXqkzrOdwk8U3oIebC2JYOFyn5H3Ap9UMGXug+Ki2LmB7tMf5dalMM ZVCDWaE8AMUENE4AAGM9ra/L6etUNOIO0ErUUIZBw2fED6xgcVUj4n0J8njSKMLiHhDq 3RSDUZLhG7dELbTj5yEBthasUqochW4FQpYHaE7A4DDZISu4NzoO7YCDvjyVHh/+0kez Q/9AxIKsRcAG6T9teNyd22CpINizKC3dGf0SNqEE+HV2c5jGdtnYolw6HhbMAQXhnNos dhUmpaWaiEkUvMXdA6UTMErbxRxVVW94eEBCxXzuU2panAyvzOg+/s0oQLr4YBUmYge/ OXLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=9blV1H9Js4on1Ru4pm7hErJIva7kNEymOz2IOkz5vus=; b=Gqg0wHBpWW7FjYXZ4ikeSoprkggg1hzlmpftiqpJsbZAlITL+8aOn5vIl87NQEjUQN a6/FHMm4gjDw4tpG0vCgYiQVaoT8t24OahrK14FbbxjGKhtstdk/cxwMLqWCCJjWcbe1 8LL9RwW6u7yjiIIFRdi3AProD9hE/50JtMPjq21TA0x9xvVQNa/6XduDB8Etoihsaaqd u1jzoPu7hamrUpx7trnazMr05sGVP+Yt58v45CH8uCYkl3CVztdImXCud4Br71yhgT+Z b1rn25dlecTqmq3XdfejSUofMhs1tNmG40Fsk6J0Na0qkAF9zO7onZzlpKRpwm1sVWVD wQig== X-Gm-Message-State: ANhLgQ1WPHQMEsk3hVIvnfAP93pcAhe2exn9vMFFSoBQ+tv53tqIFLF9 fNn86cEY3WeiAqFuWEtzxO5kWyk+FF1fGlsdDVl5Qg== X-Google-Smtp-Source: ADFU+vukaA/yWKn49R6q5KefPeW7YOl72sG3FHyafQT6fGH4fTrRy/6qZjVmQqrm5Iuva8UOjqwXVAuPJ2XknyT1hPQ= X-Received: by 2002:a05:6808:8cb:: with SMTP id k11mr2652699oij.48.1585674223782; Tue, 31 Mar 2020 10:03:43 -0700 (PDT) MIME-Version: 1.0 References: <20200325191830.16553-1-f4bug@amsat.org> <20200325191830.16553-13-f4bug@amsat.org> In-Reply-To: From: Peter Maydell Date: Tue, 31 Mar 2020 18:03:32 +0100 Message-ID: Subject: Re: [PATCH-for-5.0 12/12] hw/riscv/sifive_u: Add missing error-propagation code To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::236 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paul Burton , Sagar Karandikar , "Michael S. Tsirkin" , Jason Wang , Mark Cave-Ayland , QEMU Developers , Alistair Francis , "Edgar E. Iglesias" , Markus Armbruster , Aleksandar Markovic , Palmer Dabbelt , Aleksandar Rikalo , Richard Henderson , Eduardo Habkost , Alistair Francis , qemu-arm , David Gibson , "open list:RISC-V" , Bastian Koppelmann , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , Andrew Baumann , Jean-Christophe Dubois , qemu-ppc , Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, 31 Mar 2020 at 18:02, Philippe Mathieu-Daud=C3=A9 wrote > What about this memory_region_init_rom() call (and later > memory_region_init_ram) using error_fatal, same reasoning right? Yes. -- PMM From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jJKIo-0002SJ-Ug for mharc-qemu-riscv@gnu.org; Tue, 31 Mar 2020 13:03:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47017) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJKIl-0002Nc-UG for qemu-riscv@nongnu.org; Tue, 31 Mar 2020 13:03:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jJKIk-00004v-Eq for qemu-riscv@nongnu.org; Tue, 31 Mar 2020 13:03:47 -0400 Received: from mail-oi1-x22b.google.com ([2607:f8b0:4864:20::22b]:39014) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jJKIj-0008VK-DL for qemu-riscv@nongnu.org; Tue, 31 Mar 2020 13:03:45 -0400 Received: by mail-oi1-x22b.google.com with SMTP id d63so19543170oig.6 for ; Tue, 31 Mar 2020 10:03:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=9blV1H9Js4on1Ru4pm7hErJIva7kNEymOz2IOkz5vus=; b=SLv0dQ7u1fEVRXqkzrOdwk8U3oIebC2JYOFyn5H3Ap9UMGXug+Ki2LmB7tMf5dalMM ZVCDWaE8AMUENE4AAGM9ra/L6etUNOIO0ErUUIZBw2fED6xgcVUj4n0J8njSKMLiHhDq 3RSDUZLhG7dELbTj5yEBthasUqochW4FQpYHaE7A4DDZISu4NzoO7YCDvjyVHh/+0kez Q/9AxIKsRcAG6T9teNyd22CpINizKC3dGf0SNqEE+HV2c5jGdtnYolw6HhbMAQXhnNos dhUmpaWaiEkUvMXdA6UTMErbxRxVVW94eEBCxXzuU2panAyvzOg+/s0oQLr4YBUmYge/ OXLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=9blV1H9Js4on1Ru4pm7hErJIva7kNEymOz2IOkz5vus=; b=TZAV6nTznqVE0I8r9V03nc1RA62B11YpH5bxMyTDpZXsun0unIByC+uvNRvfqmrn1r KpbxX7J7fSfqFUI4iI3UV0PgCETEZJfYXjLjcSumC8H4JTqkC5RDagmRPhJM8lMjHCoL HZ6RaojtMXHVA7OHaCB4UUlDMe8T9baL4RCZNEQz1TSLMuhiKDbHPvFzVZWKwuYmHIcW cWGuMTWAVypLv/FJFujqppzQ+0UpgdAB7GEkoQ76RYoRGPhe8zvqWBPOQfpjdcDvN4gJ mAYJRSSrs9f2fyy0nYhkf+enSK72AQudPXcJYVUkx1cL593rXHBBDTbJtMVHUY0x2x8P uUBg== X-Gm-Message-State: ANhLgQ3/riJmLFg3qD4eIkunLbK3Oc1jqgrW6JLue7qEtl6D772jjeEO hSrYpqGvmacSJxqsLkOOMvojVfarRPSnah25JLW3Aw== X-Google-Smtp-Source: ADFU+vukaA/yWKn49R6q5KefPeW7YOl72sG3FHyafQT6fGH4fTrRy/6qZjVmQqrm5Iuva8UOjqwXVAuPJ2XknyT1hPQ= X-Received: by 2002:a05:6808:8cb:: with SMTP id k11mr2652699oij.48.1585674223782; Tue, 31 Mar 2020 10:03:43 -0700 (PDT) MIME-Version: 1.0 References: <20200325191830.16553-1-f4bug@amsat.org> <20200325191830.16553-13-f4bug@amsat.org> In-Reply-To: From: Peter Maydell Date: Tue, 31 Mar 2020 18:03:32 +0100 Message-ID: Subject: Re: [PATCH-for-5.0 12/12] hw/riscv/sifive_u: Add missing error-propagation code To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Cc: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , QEMU Developers , Alistair Francis , Paul Burton , Palmer Dabbelt , "Edgar E. Iglesias" , qemu-ppc , Jason Wang , Sagar Karandikar , Richard Henderson , Eduardo Habkost , David Gibson , Mark Cave-Ayland , Alistair Francis , Bastian Koppelmann , qemu-arm , "open list:RISC-V" , Andrew Baumann , Aleksandar Markovic , Jean-Christophe Dubois , "Michael S. Tsirkin" , Markus Armbruster , Aurelien Jarno , Aleksandar Rikalo , Paolo Bonzini , Marcel Apfelbaum Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::22b X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Mar 2020 17:03:50 -0000 On Tue, 31 Mar 2020 at 18:02, Philippe Mathieu-Daud=C3=A9 wrote > What about this memory_region_init_rom() call (and later > memory_region_init_ram) using error_fatal, same reasoning right? Yes. -- PMM