From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41B89C433E1 for ; Tue, 25 Aug 2020 13:07:41 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EE15620738 for ; Tue, 25 Aug 2020 13:07:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="pWnKHuTW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EE15620738 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35244 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kAYfs-0003fO-8J for qemu-devel@archiver.kernel.org; Tue, 25 Aug 2020 09:07:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42346) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kAYfL-0003FZ-Pa for qemu-devel@nongnu.org; Tue, 25 Aug 2020 09:07:07 -0400 Received: from mail-ej1-x643.google.com ([2a00:1450:4864:20::643]:43082) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kAYfJ-0002Fv-Pp for qemu-devel@nongnu.org; Tue, 25 Aug 2020 09:07:07 -0400 Received: by mail-ej1-x643.google.com with SMTP id m22so16397167eje.10 for ; Tue, 25 Aug 2020 06:07:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=37Ox2hNGcqsCDVVBsuIyvU8yJLJUl5E0CCZj7cUv+7g=; b=pWnKHuTWsDnM4img7apCa4Ed4QQ14eehDDfHN4PqpaKw5MUZ3VR6kbbuQnP/i37/rw ZopXwgOkQBaNjMg/6jqohf6XWlSD45YVudhZQAbxMSTMHhDm90OjPIYxjcIqd6RipB47 mEq6drLLbafTjhh89iNsaHqEcPhC+aF86B/7iOJOhd4PP9scf71AockHLLE8TXRv/Fhl mu92HKSuK/w4KpeW59utT9qqWH/PCIoRKC4ApchhzYD+3Yko5Q3r0D416kNVstRjfAu2 Oj3DEknFilqX7dRtM17W+ivXEzQbhj5KMrMCDoCZvrDLugmc4tDmlDD+UjV9eQfn099q YpdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=37Ox2hNGcqsCDVVBsuIyvU8yJLJUl5E0CCZj7cUv+7g=; b=Sd5lrwCqM3Gu7rSPAFAQnD66lH5V2ZS+HDx4O/iWkPHGB2jkY8xZlOHbgIzjfYROBl cSUg2HLVoGblbSgUgmjoXbUtewIHe6oiUr7h5M+x03KBGTHtlEBCpdDxh/a37dnXU3kl FziV2fAdy+n9/ITTQrFeTuhQu74vJ1ORlCkQeoxMBifQ+eH2jhWAOLfR8/fn76W9Fizv Ax3g1Swuob/M3WTyLU2iVrDTBkOITT92fEtGSBxPn1E0s5v+zVa73GOKv0ERnWmbdNK/ Cx+Ulm0jYk+TTFtkUQXpczAaXH6I7MO37bHTzYf7JGkbd17pzOWpgzDxaKBYM/Tsp1gH lPhQ== X-Gm-Message-State: AOAM533TXYITUHHgvM622Hyhe7yZ2tiojKeHRO9mO7ar0ITozYNnK0F7 xTLUT35OcB/1mXp1SvAN8GjH7WEZjp+L40QEwyz/GQ== X-Google-Smtp-Source: ABdhPJwIW7hVPglHFivq0WRvW6QYvO0dS1u7twOZuIh1ScRsyi+Hoq2rJ6Kawpde+xsIor6i3iDDaeNEZpL3Mm81cdQ= X-Received: by 2002:a17:906:2cc2:: with SMTP id r2mr10283839ejr.482.1598360824205; Tue, 25 Aug 2020 06:07:04 -0700 (PDT) MIME-Version: 1.0 References: <20200815013145.539409-1-richard.henderson@linaro.org> <20200815013145.539409-15-richard.henderson@linaro.org> In-Reply-To: <20200815013145.539409-15-richard.henderson@linaro.org> From: Peter Maydell Date: Tue, 25 Aug 2020 14:06:52 +0100 Message-ID: Subject: Re: [PATCH 14/20] target/arm: Generalize inl_qrdmlah_* helper functions To: Richard Henderson Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::643; envelope-from=peter.maydell@linaro.org; helo=mail-ej1-x643.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Sat, 15 Aug 2020 at 02:32, Richard Henderson wrote: > > Unify add/sub helpers and add a parameter for rounding. > This will allow saturating non-rounding to reuse this code. > > Signed-off-by: Richard Henderson > --- > /* Signed saturating rounding doubling multiply-accumulate high half, 32-bit */ > -static int32_t inl_qrdmlah_s32(int32_t src1, int32_t src2, > - int32_t src3, uint32_t *sat) > +static int32_t do_sqrdmlah_s(int32_t src1, int32_t src2, int32_t src3, > + bool neg, bool round, uint32_t *sat) > { > /* Simplify similarly to int_qrdmlah_s16 above. */ > int64_t ret = (int64_t)src1 * src2; > - ret = ((int64_t)src3 << 31) + ret + (1 << 30); > + if (neg) { > + ret = -ret; > + } > + ret = ((int64_t)src3 << 31) + (round << 30); Shouldn't this be "+=" as with the _h version earlier ? (risu testing ought to catch this -- do we have a coverage hole?) > ret >>= 31; > + > if (ret != (int32_t)ret) { > *sat = 1; > ret = (ret < 0 ? INT32_MIN : INT32_MAX); Otherwise Reviewed-by: Peter Maydell thanks -- PMM