From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33790) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YZNHH-00054S-Lb for qemu-devel@nongnu.org; Sat, 21 Mar 2015 13:33:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YZNH9-0006p5-7v for qemu-devel@nongnu.org; Sat, 21 Mar 2015 13:33:39 -0400 Received: from mail-ie0-f173.google.com ([209.85.223.173]:33180) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YZNH9-0006ox-44 for qemu-devel@nongnu.org; Sat, 21 Mar 2015 13:33:31 -0400 Received: by iecvj10 with SMTP id vj10so10546879iec.0 for ; Sat, 21 Mar 2015 10:33:30 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <550C3B78.3050802@hotmail.com> From: Peter Maydell Date: Sat, 21 Mar 2015 17:33:10 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH 1/6 v7] target-tilegx: Firstly add TILE-Gx with minimized features List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chen Gang Cc: Riku Voipio , qemu-devel , Chris Metcalf , "walt@tilera.com" , =?UTF-8?Q?Andreas_F=C3=A4rber?= , "rth@twiddle.net" On 20 March 2015 at 23:57, Chen Gang wrote: > For 'opcode_tilegx.h', it comes from Linux kernel which is already more > than 1000 lines. For me, I still suggest to let it within one patch. Right, for that sort of special case you should put it in a single patch which is just "Import copy of whatever.h from Linux kernel", and which has nothing else in it except for the imported file or files, and which makes no QEMU specific changes to those files. Then people can skim through that patch quickly knowing they don't have to look for any changes or extras that do need review. (If there is some tweak that needs to be made for QEMU's purposes that can go in a subsequent patch.) > For 'translate.c', I try to split it into 3 patches: > > - parsing bundle and decode to the first level of pipe, > > - parsing 2nd level of pipe. > > - generate tcg code. > > For the left files: > > - 'configure', 'Makefile.obj', 'tilegx-linux-user.mak' are in a patch. > > - 'cpu*' are in a patch > > - 'help.*' are in a patch. I would suggest that rather than having "cpu* in one patch and help* in another" (ie a split by file), you split things functionally, so you might have a patch adding "support for instruction group foo" which includes everything needed for those instructions including the translate.c changes and the helper functions that get called by the generated code. Remember to make sure that everything still compiles at every step in the patch series. -- PMM