From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:42213) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QynKc-00085C-Rw for qemu-devel@nongnu.org; Wed, 31 Aug 2011 12:08:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QynKX-0008WO-21 for qemu-devel@nongnu.org; Wed, 31 Aug 2011 12:08:02 -0400 Received: from mail-qw0-f45.google.com ([209.85.216.45]:62560) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QynKW-0008RM-OR for qemu-devel@nongnu.org; Wed, 31 Aug 2011 12:07:56 -0400 Received: by qwj8 with SMTP id 8so560994qwj.4 for ; Wed, 31 Aug 2011 09:07:55 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1314806132-32389-3-git-send-email-peter.maydell@linaro.org> References: <1314806132-32389-1-git-send-email-peter.maydell@linaro.org> <1314806132-32389-3-git-send-email-peter.maydell@linaro.org> Date: Wed, 31 Aug 2011 17:07:54 +0100 Message-ID: From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH 2/2] omap_intc: Qdevify List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Riku Voipio , =?UTF-8?Q?Juha_Riihim=C3=A4ki?= , patches@linaro.org On 31 August 2011 16:55, Peter Maydell wrote: > Convert the omap_intc devices to qdev. This includes adding > a 'revision' property which will be needed for omap3. Incidentally this patch is a test case for a false positive in checkpatch.pl, which complains: ERROR: need consistent spacing around '*' (ctx:WxV) #95: FILE: hw/omap.h:864: + DeviceState *ih[2]; ^ (it seems to be happy with 'struct DeviceState *ih[2];' and 'DeviceState *ih;' but not the combination of plain typename and array member.) -- PMM