All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Peter Crosthwaite <crosthwaitepeter@gmail.com>
Cc: "Peter Crosthwaite" <crosthwaite.peter@gmail.com>,
	"QEMU Developers" <qemu-devel@nongnu.org>,
	"Alistair Francis" <alistair.francis@xilinx.com>,
	"sridhar kulkarni" <sridhar_kulk@yahoo.com>,
	qemu-arm <qemu-arm@nongnu.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Piotr Król" <piotr.krol@3mdeb.com>
Subject: Re: [Qemu-devel] [PATCH v1 03/17] linux-user: arm: handle CPSR.E correctly in strex emulation
Date: Tue, 19 Jan 2016 16:24:59 +0000	[thread overview]
Message-ID: <CAFEAcA-cbMNM2-=n6DS6vn5Z9MJdQZ-zW+jxMQEtHbCmspoL1Q@mail.gmail.com> (raw)
In-Reply-To: <dd65260edbfddabf929355be5e1f4145b12ab964.1453100525.git.crosthwaite.peter@gmail.com>

On 18 January 2016 at 07:12, Peter Crosthwaite
<crosthwaitepeter@gmail.com> wrote:
> From: Paolo Bonzini <pbonzini@redhat.com>
>
> Now that CPSR.E is set correctly, prepare for when setend will be able
> to change it; bswap data in and out of strex manually by comparing
> SCTLR.B, CPSR.E and TARGET_WORDS_BIGENDIAN (we do not have the luxury
> of using TCGMemOps).
>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> [ PC changes:
>   * Remove BE32 support
> ]
> Signed-off-by: Peter Crosthwaite <crosthwaite.peter@gmail.com>
> ---

I reviewed this with the BE32 changes in it, but this version is
missing them. I don't really want to go through thinking about
whether all the cases work again only with the BE32 cases
behaving different, when I did that the first time round
and will presumably have to do it again later when the BE32
support gets added back in again :-(

thanks
-- PMM

  reply	other threads:[~2016-01-19 16:25 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-18  7:12 [Qemu-devel] [PATCH v1 00/17] ARM big-endian and setend support Peter Crosthwaite
2016-01-18  7:12 ` [Qemu-devel] [PATCH v1 01/17] linux-user: arm: fix coding style for some linux-user signal functions Peter Crosthwaite
2016-01-18  7:12 ` [Qemu-devel] [PATCH v1 02/17] linux-user: arm: set CPSR.E/SCTLR.E0E correctly for BE mode Peter Crosthwaite
2016-01-19 16:22   ` Peter Maydell
2016-01-18  7:12 ` [Qemu-devel] [PATCH v1 03/17] linux-user: arm: handle CPSR.E correctly in strex emulation Peter Crosthwaite
2016-01-19 16:24   ` Peter Maydell [this message]
2016-01-18  7:12 ` [Qemu-devel] [PATCH v1 04/17] target-arm: implement SCTLR.EE Peter Crosthwaite
2016-01-19 15:58   ` Peter Maydell
2016-02-27 21:56     ` Peter Crosthwaite
2016-01-18  7:12 ` [Qemu-devel] [PATCH v1 05/17] target-arm: pass DisasContext to gen_aa32_ld*/st* Peter Crosthwaite
2016-01-19 16:08   ` Peter Maydell
2016-01-18  7:12 ` [Qemu-devel] [PATCH v1 06/17] target-arm: introduce disas flag for endianness Peter Crosthwaite
2016-01-19 16:08   ` Peter Maydell
2016-01-18  7:12 ` [Qemu-devel] [PATCH v1 07/17] target-arm: a64: Add endianness support Peter Crosthwaite
2016-01-19 16:09   ` Peter Maydell
2016-01-18  7:12 ` [Qemu-devel] [PATCH v1 08/17] target-arm: cpu: Move cpu_is_big_endian to header Peter Crosthwaite
2016-01-18 21:52   ` Alistair Francis
2016-01-19 16:11   ` Peter Maydell
2016-02-27 22:02     ` Peter Crosthwaite
2016-01-18  7:12 ` [Qemu-devel] [PATCH v1 09/17] target-arm: introduce tbflag for endianness Peter Crosthwaite
2016-01-19 16:15   ` Peter Maydell
2016-01-18  7:12 ` [Qemu-devel] [PATCH v1 10/17] target-arm: implement setend Peter Crosthwaite
2016-01-19 16:29   ` Peter Maydell
2016-02-27 22:14     ` Peter Crosthwaite
2016-01-18  7:12 ` [Qemu-devel] [PATCH v1 11/17] linux-user: arm: pass env to get_user_code_* Peter Crosthwaite
2016-01-18  7:12 ` [Qemu-devel] [PATCH v1 12/17] target-arm: implement SCTLR.B, drop bswap_code Peter Crosthwaite
2016-01-19 17:21   ` Peter Maydell
2016-01-18  7:12 ` [Qemu-devel] [PATCH v1 13/17] arm: linux-user: don't set CPSR.E in BE32 mode Peter Crosthwaite
2016-01-19 17:26   ` Peter Maydell
2016-01-19 17:35     ` Peter Maydell
2016-02-27 22:22       ` Peter Crosthwaite
2016-01-18  7:12 ` [Qemu-devel] [PATCH v1 14/17] target-arm: implement BE32 mode in system emulation Peter Crosthwaite
2016-01-19 17:39   ` Peter Maydell
2016-01-18  7:12 ` [Qemu-devel] [PATCH v1 15/17] loader: add API to load elf header Peter Crosthwaite
2016-01-19 17:50   ` Peter Maydell
2016-02-27 22:46     ` Peter Crosthwaite
2016-01-18  7:12 ` [Qemu-devel] [PATCH v1 16/17] loader: Add data swap option to load-elf Peter Crosthwaite
2016-01-19 17:53   ` Peter Maydell
2016-02-27 23:14     ` Peter Crosthwaite
2016-02-28 15:28       ` Peter Maydell
2016-02-28 20:16         ` Peter Crosthwaite
2016-01-18  7:12 ` [Qemu-devel] [PATCH v1 17/17] arm: boot: Support big-endian elfs Peter Crosthwaite
2016-01-19 18:06   ` Peter Maydell
2016-02-27 23:59     ` Peter Crosthwaite
2016-01-19 18:06 ` [Qemu-devel] [PATCH v1 00/17] ARM big-endian and setend support Peter Maydell
2016-03-01  5:27 ` Stefan Weil
2016-03-01 18:26   ` Peter Crosthwaite
2016-03-01 18:43   ` Peter Crosthwaite
2016-03-01 21:03     ` Paolo Bonzini
2016-03-01 21:34     ` Andrew Baumann
2016-03-02  5:31       ` Peter Crosthwaite

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA-cbMNM2-=n6DS6vn5Z9MJdQZ-zW+jxMQEtHbCmspoL1Q@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=alistair.francis@xilinx.com \
    --cc=crosthwaite.peter@gmail.com \
    --cc=crosthwaitepeter@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=piotr.krol@3mdeb.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sridhar_kulk@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.