Re: [Qemu-devel] [PATCH 2/3] hw/intc/arm_gicv3_cpuif: Don't let BPR be set below its minimum

From: Peter Maydell <peter.maydell@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: qemu-arm <qemu-arm@nongnu.org>,
	QEMU Developers <qemu-devel@nongnu.org>,
	"patches@linaro.org" <patches@linaro.org>
Subject: Re: [Qemu-devel] [PATCH 2/3] hw/intc/arm_gicv3_cpuif: Don't let BPR be set below its minimum
Date: Tue, 30 May 2017 10:47:44 +0100	[thread overview]
Message-ID: <CAFEAcA-d1oZazep6-HbKDJ7dY-gAZYf+MXghDPcKSHGKWLTnEw@mail.gmail.com> (raw)
In-Reply-To: <ce532829-b11b-7992-3fc4-3e21210c66f0@amsat.org>

On 14 May 2017 at 06:31, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> On 04/26/2017 02:13 PM, Peter Maydell wrote:
>> +    minval = (grp == GICV3_G1NS) ? GIC_MIN_BPR_NS : GIC_MIN_BPR;
>> +    if (value < minval) {
>> +        value = minval;
>> +    }
>> +
>
>
> which is:
>
>     if (grp == GICV3_G1NS) {
>         value = MAX(value, GIC_MIN_BPR_NS);
>     }

Only if you assume GIC_MIN_BPR must always be 0, which isn't
necessarily the case. (One day we might need to update it to
be a per-device configurable parameter, like the VBPR min.)

thanks
-- PMM