From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D183C4338F for ; Fri, 20 Aug 2021 09:36:05 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E624E60E90 for ; Fri, 20 Aug 2021 09:36:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E624E60E90 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:51494 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mH0wW-0002E2-0J for qemu-devel@archiver.kernel.org; Fri, 20 Aug 2021 05:36:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37002) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mH0vM-0001QH-Mh for qemu-devel@nongnu.org; Fri, 20 Aug 2021 05:34:52 -0400 Received: from mail-ej1-x62f.google.com ([2a00:1450:4864:20::62f]:39576) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mH0vK-0008GE-Tr for qemu-devel@nongnu.org; Fri, 20 Aug 2021 05:34:52 -0400 Received: by mail-ej1-x62f.google.com with SMTP id gr13so18943890ejb.6 for ; Fri, 20 Aug 2021 02:34:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=81vRd7z3FXbh6DTFbrouJbyTo6bDKK1+aEaGwJIZHgY=; b=o/AA5J2qt+2dblrhCEdemQ4xLkWYUrHs7ynw4XSDWqs4aA0X6WUZP7Bq7Rs1McXOJV KLiBbRVOEUS07sRxtOn7KJbdPVLFtwt8sdLZLGbQkELUb8lvBr1TQsiIvq+LlBJUsgIA 5REbJs9YH4ld3tIlwY4TSByPN47cB3gS/lzQCwSZ6YamEN4K2Y9KNRJfXPht6zxe1qWE FQgUO16kXxSrzOIy4VcyXjrN148MkUEsypAHfxQZXjPvvAuWMbd+1zfvGGQUgOQJm9Gl wLgPL869hV6F7J9dAQb139OhxTTJ549vx66EEF90aai0RLvZ8kA4b+LSIHeHtvNPje1b RSbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=81vRd7z3FXbh6DTFbrouJbyTo6bDKK1+aEaGwJIZHgY=; b=f48QoU3dq8uTQ2aSm5YuzATQvO+3xTxrD3SxIA+YVR+7xa5MRuPHXeRcP//5bkgkAP plcYfchBPX2ovPjzsbu+gbv8W5kZ1ZGtO9fnpHqYtl9e3uBlJ+YGmdyTaIR26tVMLEVG w5tcJvIYVnpLeoYay2dXiN2OGGwEkrde9X59tFw/jkDVRcXrFoL8ukFNOAXISZPqyPMM YYWEqL6pREKHT5UCfyE3jimskHxZZVcIexv8RPMZLMgi1OtRZGbK+cM/vVMR/0h1i9DG XVg/AM/aUaPVFOqrWykWXeo7v6PVuyW4TN/lEVoz3vIQy8b3cZtsYJGE+BHIYtFhNT0C /Wkg== X-Gm-Message-State: AOAM533EYYh8RCOkjCDIP7YgCUIsYE+Ok9PLJ7XZ+Qs+ezzGQuFF0sP4 q6AkdL54/IkPykrp2LcpZmnddQfycegx79Saa3Gtbg== X-Google-Smtp-Source: ABdhPJyxElR/zmDxJB5HT94YqSJNJpIpRi9SAebfi8iG5r9V40osUnuRvjqt1v70/d4ITA0ddxjpA/Y3iSTlrI8KqRo= X-Received: by 2002:a17:907:1048:: with SMTP id oy8mr20176237ejb.382.1629452089344; Fri, 20 Aug 2021 02:34:49 -0700 (PDT) MIME-Version: 1.0 References: <20210818191920.390759-1-richard.henderson@linaro.org> <20210818191920.390759-60-richard.henderson@linaro.org> In-Reply-To: <20210818191920.390759-60-richard.henderson@linaro.org> From: Peter Maydell Date: Fri, 20 Aug 2021 10:34:03 +0100 Message-ID: Subject: Re: [PATCH v3 59/66] accel/tcg: Handle SIGBUS in handle_cpu_signal To: Richard Henderson Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::62f; envelope-from=peter.maydell@linaro.org; helo=mail-ej1-x62f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 18 Aug 2021 at 21:13, Richard Henderson wrote: > > We've been registering host SIGBUS, but then treating it > exactly like SIGSEGV. > > Handle BUS_ADRALN via cpu_unaligned_access, but allow other > SIGBUS si_codes to continue into the host-to-guest signal > coversion code in host_signal_handler. Unwind the guest > state so that we report the correct guest PC for the fault. You can't rely on alignment faults being marked by BUS_ADRALN: eg MIPS doesn't give you that si_code. How much does that matter for our use of it here ? -- PMM