From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55759) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTvV6-0000Bo-B1 for qemu-devel@nongnu.org; Tue, 16 Sep 2014 12:21:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XTvUz-0006fk-7m for qemu-devel@nongnu.org; Tue, 16 Sep 2014 12:21:08 -0400 Received: from mail-la0-f47.google.com ([209.85.215.47]:38993) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTvUz-0006fD-1L for qemu-devel@nongnu.org; Tue, 16 Sep 2014 12:21:01 -0400 Received: by mail-la0-f47.google.com with SMTP id mc6so118127lab.20 for ; Tue, 16 Sep 2014 09:20:56 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1410882204-9836-1-git-send-email-pbonzini@redhat.com> References: <1410882204-9836-1-git-send-email-pbonzini@redhat.com> From: Peter Maydell Date: Tue, 16 Sep 2014 09:20:36 -0700 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [RFC PATCH] tests: use g_test_trap_fork for glib between 2.16 and 2.38 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: QEMU Developers , Eduardo Habkost , "Michael S. Tsirkin" On 16 September 2014 08:43, Paolo Bonzini wrote: > Glib recently introduced a robust way to run tests in a subprocess, > which is used in test-qdev-global-props. However, we would like > to have the same tests run with older versions of glib, and the > older fork-based mechanisms works well enough. > > This still requires: > > - bumping the minimum required version from 2.12 to 2.16. I suggest > bumping to the currently required version for Windows, which is 2.20 > (released March 2009). The commit message for a52d28afb suggests that this bump would be dropping support for RHEL5. That doesn't seem like a great idea to me, especially if it's only for the benefit of a test program. On the other hand your patch doesn't actually bump the required version, so I'm a bit confused. -- PMM