From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45636) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLyM0-00067e-7i for qemu-devel@nongnu.org; Wed, 10 Oct 2012 11:37:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TLyLu-00061q-4N for qemu-devel@nongnu.org; Wed, 10 Oct 2012 11:37:48 -0400 Received: from mail-ie0-f173.google.com ([209.85.223.173]:55771) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLyLu-00061j-0B for qemu-devel@nongnu.org; Wed, 10 Oct 2012 11:37:42 -0400 Received: by mail-ie0-f173.google.com with SMTP id 17so1092996iea.4 for ; Wed, 10 Oct 2012 08:37:41 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1348935086-11336-1-git-send-email-abarcelo@ac.upc.edu> Date: Wed, 10 Oct 2012 16:37:41 +0100 Message-ID: From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH 0/2] signal: Preparing safe sigprocmask wrapper on qemu-user List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Barcelo Cc: Riku Voipio , qemu-devel@nongnu.org On 8 October 2012 19:42, Alex Barcelo wrote: > okay, now I see that this lacks a lot of "presentation". > Before sending a v2, is there something more that I should correct? Well, yes, your cover letter could be a little more verbose, but I think mostly it's just that nobody's got round to reviewing the patches yet. I'll have a look at them in a moment. One thing that is definitely missing and is critical is that you need to include a Signed-off-by: line in your patches' commit messages: we cannot commit them without one. (http://wiki.qemu.org/Contribute/SubmitAPatch mentions this and has some other hints, if you haven't read it.) > And one netiquete question, test-breaking code should be in the > description (cover, 00/00)? On a next post in the same thread? Another > thread? In the cover letter is fine. -- PMM