From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43032C433F5 for ; Mon, 15 Nov 2021 13:41:01 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD8EC63225 for ; Mon, 15 Nov 2021 13:41:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CD8EC63225 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:54146 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mmcEE-0004KN-3C for qemu-devel@archiver.kernel.org; Mon, 15 Nov 2021 08:40:58 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34386) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmcCJ-0003Fx-Gu for qemu-devel@nongnu.org; Mon, 15 Nov 2021 08:38:59 -0500 Received: from [2a00:1450:4864:20::32e] (port=56047 helo=mail-wm1-x32e.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mmcCG-0004MH-Oh for qemu-devel@nongnu.org; Mon, 15 Nov 2021 08:38:59 -0500 Received: by mail-wm1-x32e.google.com with SMTP id p18so4635942wmq.5 for ; Mon, 15 Nov 2021 05:38:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NJeT81Ln08sVnOvClQx7gZy/obIymPr4zWjhEVgsEjA=; b=qZRH7NGmp1PMciSQoyUMYVXlFymS4BExsXAseBK1B8gjNV7fhXTfSBMzGWpMUvhW33 ObFcgmCeoLByoNeaNhtvBwJ254GuzHATVvjBBtZHYMjgrlIklX0TiqCeCvXo/HJQFgZT RtDmcu0GZJQ1korC7xr1allEf3AuqyaF7yAjb5tfS7wQzCCqwtHXotneub2OtKC/tSat slvDZ6PurEUAZqLTuziK0JygPkdx7tGK4Hmt/24//NdaHnG9FTWR0P2nFJajVIpgJ93a rYONTU+dCi82DRk3il1SExHOH6ouF2YbXBB8iGPL0DE8fg26aWUaN1VWZQejgimbBX0F LzqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NJeT81Ln08sVnOvClQx7gZy/obIymPr4zWjhEVgsEjA=; b=QMpT5kmYoToALnsIrrY67dr/t3iDWwhoOz3yWIa/W/JmVki0wSweQ02Rdrn5R8l10I a8EGSrL9FQwA1tNwvPe6xCtbzySAstbWNNMM4tao+j9PuDlP8Lb8ML1ZzDLpAeLaM4Eg MpGvfivxFxYvvmwqySXpmlehRYPndq9pKV9XHTdszPAzLm3yLrkk+9T9RCwcR1AdVz6L 9pIuglFpNIzFEfD1URzxJRsgfqXMHhGxqhSCqnNLIQmAiFwIyqNeXTrssZiX8izxeGvk QlHp1MYqIM/lcpQIyL/rZ3IYILm/dpYAr7fKOubOYxCtdgPg9lyxpjWnkjeDNIJWjmcX MWJA== X-Gm-Message-State: AOAM530EcwWsHg833Y26KjT2x8bUPe+baUJjY9YLgYMsliYV6f26rioZ gUh9WGnG/TTz1A6/soAuQssWGJD+mXfJQjWprrpQPw== X-Google-Smtp-Source: ABdhPJz4odgPhu4JFqUnTGqDJoTamgtr7UTskdt2Lr52NbabZ8CaJDn/HYHHfTJu77HHUwTODqDR4EJy5QAjLypMu2E= X-Received: by 2002:a05:600c:3486:: with SMTP id a6mr26357463wmq.32.1636983535036; Mon, 15 Nov 2021 05:38:55 -0800 (PST) MIME-Version: 1.0 References: <20211115125536.3341681-1-armbru@redhat.com> <20211115125536.3341681-3-armbru@redhat.com> In-Reply-To: <20211115125536.3341681-3-armbru@redhat.com> From: Peter Maydell Date: Mon, 15 Nov 2021 13:38:43 +0000 Message-ID: Subject: Re: [PATCH RFC 2/2] hw: Replace drive_get_next() by drive_get() To: Markus Armbruster Content-Type: text/plain; charset="UTF-8" X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::32e (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::32e; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x32e.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bin.meng@windriver.com, mark.cave-ayland@ilande.co.uk, qemu-devel@nongnu.org, edgar.iglesias@gmail.com, sundeep.lkml@gmail.com, qemu-block@nongnu.org, andrew.smirnov@gmail.com, hskinnemoen@google.com, joel@jms.id.au, atar4qemu@gmail.com, alistair@alistair23.me, b.galvani@gmail.com, nieklinnenbank@gmail.com, qemu-arm@nongnu.org, clg@kaod.org, kwolf@redhat.com, qemu-riscv@nongnu.org, andrew@aj.id.au, f4bug@amsat.org, Andrew.Baumann@microsoft.com, jcd@tribudubois.net, kfting@nuvoton.com, hreitz@redhat.com, palmer@dabbelt.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 15 Nov 2021 at 12:55, Markus Armbruster wrote: > > drive_get_next() is basically a bad idea. It returns the "next" block > backend of a certain interface type. "Next" means bus=0,unit=N, where > subsequent calls count N up from zero, per interface type. > > This lets you define unit numbers implicitly by execution order. If the > order changes, or new calls appear "in the middle", unit numbers change. > ABI break. Hard to spot in review. > > Explicit is better than implicit: use drive_get() directly. > > Signed-off-by: Markus Armbruster > --- > include/sysemu/blockdev.h | 1 - > blockdev.c | 10 ---------- > hw/arm/aspeed.c | 21 +++++++++++++-------- > hw/arm/cubieboard.c | 2 +- > hw/arm/imx25_pdk.c | 2 +- > hw/arm/integratorcp.c | 2 +- > hw/arm/mcimx6ul-evk.c | 2 +- > hw/arm/mcimx7d-sabre.c | 2 +- > hw/arm/msf2-som.c | 2 +- > hw/arm/npcm7xx_boards.c | 6 +++--- > hw/arm/orangepi.c | 2 +- > hw/arm/raspi.c | 2 +- > hw/arm/realview.c | 2 +- > hw/arm/sabrelite.c | 2 +- > hw/arm/versatilepb.c | 4 ++-- > hw/arm/vexpress.c | 6 +++--- > hw/arm/xilinx_zynq.c | 16 +++++++++------- > hw/arm/xlnx-versal-virt.c | 3 ++- > hw/arm/xlnx-zcu102.c | 6 +++--- > hw/microblaze/petalogix_ml605_mmu.c | 2 +- > hw/misc/sifive_u_otp.c | 2 +- > hw/riscv/microchip_pfsoc.c | 2 +- > hw/sparc64/niagara.c | 2 +- > 23 files changed, 49 insertions(+), 52 deletions(-) This would be easier to review if it didn't try to change all of these board/SoC models at once. Each one of them is entirely separate review work. -- PMM From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1mmcHY-0007uc-Mh for mharc-qemu-riscv@gnu.org; Mon, 15 Nov 2021 08:44:26 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35544) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmcHW-0007tq-Fb for qemu-riscv@nongnu.org; Mon, 15 Nov 2021 08:44:23 -0500 Received: from [2a00:1450:4864:20::334] (port=51945 helo=mail-wm1-x334.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mmcHQ-0005KZ-Pd for qemu-riscv@nongnu.org; Mon, 15 Nov 2021 08:44:18 -0500 Received: by mail-wm1-x334.google.com with SMTP id z200so14013063wmc.1 for ; Mon, 15 Nov 2021 05:44:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NJeT81Ln08sVnOvClQx7gZy/obIymPr4zWjhEVgsEjA=; b=qZRH7NGmp1PMciSQoyUMYVXlFymS4BExsXAseBK1B8gjNV7fhXTfSBMzGWpMUvhW33 ObFcgmCeoLByoNeaNhtvBwJ254GuzHATVvjBBtZHYMjgrlIklX0TiqCeCvXo/HJQFgZT RtDmcu0GZJQ1korC7xr1allEf3AuqyaF7yAjb5tfS7wQzCCqwtHXotneub2OtKC/tSat slvDZ6PurEUAZqLTuziK0JygPkdx7tGK4Hmt/24//NdaHnG9FTWR0P2nFJajVIpgJ93a rYONTU+dCi82DRk3il1SExHOH6ouF2YbXBB8iGPL0DE8fg26aWUaN1VWZQejgimbBX0F LzqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NJeT81Ln08sVnOvClQx7gZy/obIymPr4zWjhEVgsEjA=; b=vYBJRd/NQ6Do2BhyjHWlJRpVlCTV53DpHQaPSYq7DlJlsfgTKN+FirDKx6eSfS2yrm 8LyOvRFtHvHljgt/oy9/pWi+O+t9+3+qeyLRs7IMyzA4CY/kjHY6Bn+3cooNz9jTweEl bc3NkKbDLVDgmHuir/q8UQSMWFxyCEqAtT5wNTJL33ri8aVX1hAoGIUbsQ9/EKk3u4tE mnjBTUgQllk0oMqe0q1O/F5yGhohzMXtauDtHE5Z2D2RiQdQ6cSSQSnLRyWZ0zsrgwjo GQ+0rxuqtTaXLe8XC2iRxvM5YwEGgrHGmoTncuuyUBobtQ0DSt0kPJ/0H5M9UdNteIU7 s8Zg== X-Gm-Message-State: AOAM533lnvUwd4k4svF0jv/g+1GxtS8piYmjrU9O9XI5BwBIUo5g5MXX 6mBaZHXeToCm6UmJUS3WA01MnuFW3iHxhJy9oI9LdlI7Qjk= X-Google-Smtp-Source: ABdhPJz4odgPhu4JFqUnTGqDJoTamgtr7UTskdt2Lr52NbabZ8CaJDn/HYHHfTJu77HHUwTODqDR4EJy5QAjLypMu2E= X-Received: by 2002:a05:600c:3486:: with SMTP id a6mr26357463wmq.32.1636983535036; Mon, 15 Nov 2021 05:38:55 -0800 (PST) MIME-Version: 1.0 References: <20211115125536.3341681-1-armbru@redhat.com> <20211115125536.3341681-3-armbru@redhat.com> In-Reply-To: <20211115125536.3341681-3-armbru@redhat.com> From: Peter Maydell Date: Mon, 15 Nov 2021 13:38:43 +0000 Message-ID: Subject: Re: [PATCH RFC 2/2] hw: Replace drive_get_next() by drive_get() To: Markus Armbruster Cc: qemu-devel@nongnu.org, kwolf@redhat.com, hreitz@redhat.com, clg@kaod.org, andrew@aj.id.au, joel@jms.id.au, b.galvani@gmail.com, jcd@tribudubois.net, andrew.smirnov@gmail.com, sundeep.lkml@gmail.com, hskinnemoen@google.com, kfting@nuvoton.com, nieklinnenbank@gmail.com, Andrew.Baumann@microsoft.com, f4bug@amsat.org, edgar.iglesias@gmail.com, alistair@alistair23.me, bin.meng@windriver.com, palmer@dabbelt.com, atar4qemu@gmail.com, mark.cave-ayland@ilande.co.uk, qemu-block@nongnu.org, qemu-arm@nongnu.org, qemu-riscv@nongnu.org Content-Type: text/plain; charset="UTF-8" X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::334 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x334.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Nov 2021 13:44:23 -0000 On Mon, 15 Nov 2021 at 12:55, Markus Armbruster wrote: > > drive_get_next() is basically a bad idea. It returns the "next" block > backend of a certain interface type. "Next" means bus=0,unit=N, where > subsequent calls count N up from zero, per interface type. > > This lets you define unit numbers implicitly by execution order. If the > order changes, or new calls appear "in the middle", unit numbers change. > ABI break. Hard to spot in review. > > Explicit is better than implicit: use drive_get() directly. > > Signed-off-by: Markus Armbruster > --- > include/sysemu/blockdev.h | 1 - > blockdev.c | 10 ---------- > hw/arm/aspeed.c | 21 +++++++++++++-------- > hw/arm/cubieboard.c | 2 +- > hw/arm/imx25_pdk.c | 2 +- > hw/arm/integratorcp.c | 2 +- > hw/arm/mcimx6ul-evk.c | 2 +- > hw/arm/mcimx7d-sabre.c | 2 +- > hw/arm/msf2-som.c | 2 +- > hw/arm/npcm7xx_boards.c | 6 +++--- > hw/arm/orangepi.c | 2 +- > hw/arm/raspi.c | 2 +- > hw/arm/realview.c | 2 +- > hw/arm/sabrelite.c | 2 +- > hw/arm/versatilepb.c | 4 ++-- > hw/arm/vexpress.c | 6 +++--- > hw/arm/xilinx_zynq.c | 16 +++++++++------- > hw/arm/xlnx-versal-virt.c | 3 ++- > hw/arm/xlnx-zcu102.c | 6 +++--- > hw/microblaze/petalogix_ml605_mmu.c | 2 +- > hw/misc/sifive_u_otp.c | 2 +- > hw/riscv/microchip_pfsoc.c | 2 +- > hw/sparc64/niagara.c | 2 +- > 23 files changed, 49 insertions(+), 52 deletions(-) This would be easier to review if it didn't try to change all of these board/SoC models at once. Each one of them is entirely separate review work. -- PMM