From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:50418)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1SrPCH-000091-6B
	for qemu-devel@nongnu.org; Wed, 18 Jul 2012 04:01:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1SrPCB-0006dK-6Y
	for qemu-devel@nongnu.org; Wed, 18 Jul 2012 04:01:25 -0400
Received: from mail-bk0-f45.google.com ([209.85.214.45]:53832)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1SrPCA-0006dA-Vi
	for qemu-devel@nongnu.org; Wed, 18 Jul 2012 04:01:19 -0400
Received: by bkcji1 with SMTP id ji1so993432bkc.4
	for <qemu-devel@nongnu.org>; Wed, 18 Jul 2012 01:01:16 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <500657F2.1080703@ozlabs.ru>
References: <500657F2.1080703@ozlabs.ru>
Date: Wed, 18 Jul 2012 09:01:16 +0100
Message-ID: <CAFEAcA-eeEuZaxynPxT15prrFNqFk14QtpZp46Fj4n_fLM3vVQ@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] qemu in full emulation on win32
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Hannes Reinecke <hare@suse.de>, qemu-devel@nongnu.org, David Gibson <david@gibson.dropbear.id.au>

On 18 July 2012 07:30, Alexey Kardashevskiy <aik@ozlabs.ru> wrote:
> 1. The size of the following is 7 bytes on linux and 8 bytes on Windows:
> struct {
>     uint32_t hi;
>     uint64_t child;
>     uint64_t parent;
>     uint64_t size;
> } __attribute__((packed)) ranges[];
>
> The structure is used between QEMU and Open Firmware (powerpc bios) so it is important.

I think this struct should use QEMU_PACKED, which will
ensure that it is packed to GCC rules rather than MS
rules.

We also seem to have let a pile of new uses of attribute((packed))
slip in in hw/mfi.h. Those are probably bugs too.

-- PMM