From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78F8BC48BDF for ; Thu, 24 Jun 2021 11:27:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3C4B7613C5 for ; Thu, 24 Jun 2021 11:27:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3C4B7613C5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40468 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lwNWW-0000lT-DX for qemu-devel@archiver.kernel.org; Thu, 24 Jun 2021 07:27:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44052) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lwNCD-0002TC-AP for qemu-devel@nongnu.org; Thu, 24 Jun 2021 07:06:58 -0400 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]:38707) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lwNCA-0003ZC-HY for qemu-devel@nongnu.org; Thu, 24 Jun 2021 07:06:56 -0400 Received: by mail-ed1-x52f.google.com with SMTP id q14so7927610eds.5 for ; Thu, 24 Jun 2021 04:06:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nPjdvn534DHuYRyFN84RDyWfp4RUMETvlQKgpiTvnDU=; b=j81K7Z9S2QdFsbCcnUdhywEXrBIh3ZRJG2WQVQW18YyZsHFJhIAUeuUzsqxCZz5zwf igcKB1l5tJjJFMJb+YONuVxF9n6RbHcyQAhCWZ/34lCkUcrWn2Ey6HDEOxY5NceiHr/v lVVOpNOtnEaA5nF1iroPbB9xr6dQRLQDfLcOaPoGi7rg1F1o4rzsWYfLieJ1uFmSYRcK ZXyoagKDw7jqd4rTM0GLlwV7KQMLmysa3FowM8igbNeELdNxBl2NV43Y/CpigOeCcg/A Mf30qWBqYe20RT0NrxwQOPoSIKCu9uGVm+/UirreejdYL3bcUi28f7nnwr6Pn7uFfLiD GPNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nPjdvn534DHuYRyFN84RDyWfp4RUMETvlQKgpiTvnDU=; b=euMfNEijhKeGpu8Bp2QczKn3qOLjMANs6vha5Mbvgibtj1MdJX6HH/Ej5ZUn8SN/qO ZTzE43Mpz5bUXIdkBdLfEPB2STK6UP6+6Lsx8g4zBSWmP6LnvbXk2RH9YSI485bFQ2QX w22CdzBAQtIBmtnM2QdLb8vBOmiOsktagGrWKkiR5ppHO9FUvrpl4fB6wXNRztwM5gqy 8JYvkZHFpvDP8f5iekp5+TbUUAqsY4WsOajgQLXdGvXCwfqZAb+xNmFyCJuyBX7Mxc+Y cKn73zvDv5yf6RIHOKAa1kLdUx0+8wm30dTY8cxznu/MhjRHMTYlWSZZj1Y6mKeq+oJd SZ/w== X-Gm-Message-State: AOAM5303pDYOhZZFgiImD1WwzF0LsNJRC2ancFeDA3v4OsL+W8aD6R8P 58Ok4KwC/4rjZTAMKPfH1vHW8WE6tElwh6OUFQZ1Iw== X-Google-Smtp-Source: ABdhPJyJHuAn/Rh5eq50JLj7dhs487Tt9iSA70Tr92HKvZMQHTm5qjgTnl1920IsG8wn76wtReUbHEuIdtlZdP+4goQ= X-Received: by 2002:a05:6402:5204:: with SMTP id s4mr6302778edd.52.1624532810766; Thu, 24 Jun 2021 04:06:50 -0700 (PDT) MIME-Version: 1.0 References: <20210624110057.2398779-1-kraxel@redhat.com> In-Reply-To: <20210624110057.2398779-1-kraxel@redhat.com> From: Peter Maydell Date: Thu, 24 Jun 2021 12:06:14 +0100 Message-ID: Subject: Re: [PATCH] acpi/ged: fix reset cause To: Gerd Hoffmann Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::52f; envelope-from=peter.maydell@linaro.org; helo=mail-ed1-x52f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Igor Mammedov , QEMU Developers , "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, 24 Jun 2021 at 12:01, Gerd Hoffmann wrote: > > Reset requests should use SHUTDOWN_CAUSE_GUEST_RESET not > SHUTDOWN_CAUSE_GUEST_SHUTDOWN. > > Reported-by: Peter Maydell > Signed-off-by: Gerd Hoffmann > --- > hw/acpi/generic_event_device.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/acpi/generic_event_device.c b/hw/acpi/generic_event_device.c > index 39c825763ad8..e28457a7d103 100644 > --- a/hw/acpi/generic_event_device.c > +++ b/hw/acpi/generic_event_device.c > @@ -207,7 +207,7 @@ static void ged_regs_write(void *opaque, hwaddr addr, uint64_t data, > return; > case ACPI_GED_REG_RESET: > if (data == ACPI_GED_RESET_VALUE) { > - qemu_system_reset_request(SHUTDOWN_CAUSE_GUEST_SHUTDOWN); > + qemu_system_reset_request(SHUTDOWN_CAUSE_GUEST_RESET); > } > return; > } > -- > 2.31.1 Reviewed-by: Peter Maydell thanks -- PMM