From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57860) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eOoXj-0004we-Sd for qemu-devel@nongnu.org; Tue, 12 Dec 2017 12:40:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eOoXi-0000k4-V1 for qemu-devel@nongnu.org; Tue, 12 Dec 2017 12:40:35 -0500 Received: from mail-oi0-x236.google.com ([2607:f8b0:4003:c06::236]:45368) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eOoXi-0000jb-Q9 for qemu-devel@nongnu.org; Tue, 12 Dec 2017 12:40:34 -0500 Received: by mail-oi0-x236.google.com with SMTP id x20so14534645oix.12 for ; Tue, 12 Dec 2017 09:40:34 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20171211213007.7353-1-andrew.smirnov@gmail.com> References: <20171211213007.7353-1-andrew.smirnov@gmail.com> From: Peter Maydell Date: Tue, 12 Dec 2017 17:40:13 +0000 Message-ID: Content-Type: text/plain; charset="UTF-8" Subject: Re: [Qemu-devel] [PATCH 00/13] i.MX FEC and SD changes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andrey Smirnov Cc: qemu-arm , Jason Wang , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , QEMU Developers , Andrey Yurovsky On 11 December 2017 at 21:29, Andrey Smirnov wrote: > Hi everyone, > > This patchset is a spin-off from original i.MX7 support submission > found here [1], containing all of the patchest that are more or less > agreed upon and are ready (hopefully!) for inclusion. > > Changes since [1]: > > - Rx buffer in FEC was moved from stack to heap to allow > worry-free expansion to 16K limit. > > - Added more comments explaining rather convoluted bit-moving > in eSHDC emuation code > > - Triple Tx ring DMA "VMState" code was changed to follow > Peter's recommendations (avoiding the need to incrememnt the > version_id) > > - FSL_IMX25_FEC_SIZE is used as a size of FEC's register file > > - Removed leftover code from "imx_fec: Change queue flushing > heuristics" > > [1] https://lists.gnu.org/archive/html/qemu-arm/2017-11/msg00045.html Hi; thanks for sending this set separately. Patch 4 ("Move Tx frame buffer away from the stack") seems to have got lost -- it isn't in the mailing list archives or my mailbox. Could you try resending that one? Incidentally we should use the new i.MX SDHCI controller in the imx6: coincidentally somebody ran into this bug recently: https://stackoverflow.com/questions/47538951/qemu-freescale-i-mx6-duallite-sabre-root-filesystem-does-not-mount/47552596 I'll retest that this patchset works with my imx6 image, and send a patch to sit on top of it to switch imx6 over to TYPE_IMX_USDHC. thanks -- PMM