All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: BALATON Zoltan <balaton@eik.bme.hu>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
	QEMU Trivial <qemu-trivial@nongnu.org>,
	Magnus Damm <magnus.damm@gmail.com>,
	Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH v3 08/13] sm501: Fix hardware cursor
Date: Fri, 3 Mar 2017 18:27:19 +0000	[thread overview]
Message-ID: <CAFEAcA-knxUep+x-svv+e6FaJ51r_6JwhBW20pR_PMF+2618OQ@mail.gmail.com> (raw)
In-Reply-To: <2631f4fa83bdb4ea9da97cb807a8ff1756db1684.1488504063.git.balaton@eik.bme.hu>

On 4 December 2016 at 18:01, BALATON Zoltan <balaton@eik.bme.hu> wrote:
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
>
> v3: simplify return expression in get_bpp

In my review on v2 I asked for the commit message to
say clearly what the bugs being fixed here are. It's
a lot easier to review a patch if I know what it's supposed
to be doing rather than having to figure it out from scratch.

thanks
-- PMM

  reply	other threads:[~2017-03-03 18:27 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-03  1:21 [Qemu-devel] [PATCH v3 00/13] Improvements for SM501 display controller emulation BALATON Zoltan
2017-02-25 18:23 ` [Qemu-devel] [PATCH v3 05/13] sm501: Get rid of base address in draw_hwc_line BALATON Zoltan
2017-02-25 18:31 ` [Qemu-devel] [PATCH v3 06/13] sm501: Add emulation of chip connected via PCI BALATON Zoltan
2017-03-03 18:25   ` Peter Maydell
2017-02-25 18:46 ` [Qemu-devel] [PATCH v3 07/13] sm501: Fix device endianness BALATON Zoltan
2017-02-25 19:19 ` [Qemu-devel] [PATCH v3 09/13] sm501: Misc clean ups BALATON Zoltan
2017-02-25 19:25 ` [Qemu-devel] [PATCH v3 10/13] sm501: Add support for panel layer BALATON Zoltan
2017-02-25 23:53 ` [Qemu-devel] [PATCH v3 12/13] sm501: Add vmstate descriptor BALATON Zoltan
2017-03-03 18:34   ` Peter Maydell
2017-03-03  0:21 ` [Qemu-devel] [PATCH v3 02/13] sm501: Use defined constants instead of literal values where available BALATON Zoltan
2017-03-03 18:21   ` Peter Maydell
2017-03-03  1:03 ` [Qemu-devel] [PATCH v3 04/13] sm501: QOMify BALATON Zoltan
2017-03-03 18:23   ` Peter Maydell
2017-03-03 18:39   ` Peter Maydell
2017-03-03 20:56     ` BALATON Zoltan
2017-03-04 12:43       ` Peter Maydell
2017-03-03  1:50 ` [Qemu-devel] [PATCH v3 13/13] ppc: Add SM501 device in config for ppc and ppcemb targets BALATON Zoltan
2017-03-03 18:34   ` Peter Maydell
2017-03-06  7:00   ` Thomas Huth
2017-03-06  9:47     ` Peter Maydell
2017-03-06  9:52       ` Thomas Huth
2017-03-06  9:55         ` Peter Maydell
2017-03-06 18:34           ` BALATON Zoltan
2017-03-03  1:50 ` [Qemu-devel] [PATCH v3 11/13] sm501: Add some more missing registers BALATON Zoltan
2017-03-03 18:33   ` Peter Maydell
2017-03-03  1:50 ` [Qemu-devel] [PATCH v3 08/13] sm501: Fix hardware cursor BALATON Zoltan
2017-03-03 18:27   ` Peter Maydell [this message]
2017-03-03  1:50 ` [Qemu-devel] [PATCH v3 03/13] sm501: Add missing arbitration control register BALATON Zoltan
2017-03-03 18:21   ` Peter Maydell
2017-03-03  1:50 ` [Qemu-devel] [PATCH v3 01/13] sm501: Fixed code style and a few typos in comments BALATON Zoltan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA-knxUep+x-svv+e6FaJ51r_6JwhBW20pR_PMF+2618OQ@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=aurelien@aurel32.net \
    --cc=balaton@eik.bme.hu \
    --cc=magnus.damm@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.