From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51418)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Syirn-0007eQ-8t
	for qemu-devel@nongnu.org; Tue, 07 Aug 2012 08:26:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Syirj-00050Z-7e
	for qemu-devel@nongnu.org; Tue, 07 Aug 2012 08:26:31 -0400
Received: from mail-gg0-f173.google.com ([209.85.161.173]:39705)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Syirj-0004zo-3c
	for qemu-devel@nongnu.org; Tue, 07 Aug 2012 08:26:27 -0400
Received: by ggna5 with SMTP id a5so223788ggn.4
	for <qemu-devel@nongnu.org>; Tue, 07 Aug 2012 05:26:26 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1344341985-10065-2-git-send-email-borntraeger@de.ibm.com>
References: <1344307320-25094-2-git-send-email-zhlcindy@linux.vnet.ibm.com>
	<1344341985-10065-2-git-send-email-borntraeger@de.ibm.com>
Date: Tue, 7 Aug 2012 13:26:26 +0100
Message-ID: <CAFEAcA-mLAvgUwSfyT52oKrKa-WG454UfVgoMVxwQ3hfogJEgA@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [RFC/PATCH 1/1] USB code fenced for s390
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: aliguori@us.ibm.com, agraf@suse.de, Li Zhang <zhlcindy@linux.vnet.ibm.com>, qemu-devel@nongnu.org, Jens Freimann <jfrei@linux.vnet.ibm.com>, Li Zhang <zhlcindy@gmail.com>, Eugene Dvurechenski <jno@linux.vnet.ibm.com>, qemu-ppc@nongnu.org, afaerber@suse.de, david@gibson.dropbear.id.au

On 7 August 2012 13:19, Christian Borntraeger <borntraeger@de.ibm.com> wrote:
> +#if defined(TARGET_HAS_USB) && (TARGET_HAS_USB == 1)
>      /* init USB devices */
>      if (usb_enabled) {
>          if (foreach_device_config(DEV_USB, usb_parse) < 0)
>              exit(1);
>      }
> +#endif

Whether there is USB or not is a property of the machine model,
not the target CPU architecture, so a TARGET_HAS_USB define
is definitely the wrong approach.

-- PMM