From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B53C4C433EF for ; Thu, 21 Apr 2022 11:17:14 +0000 (UTC) Received: from localhost ([::1]:53952 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nhUoD-0008BH-L6 for qemu-devel@archiver.kernel.org; Thu, 21 Apr 2022 07:17:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55984) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nhUc6-00044C-Mb for qemu-devel@nongnu.org; Thu, 21 Apr 2022 07:04:44 -0400 Received: from mail-yb1-xb31.google.com ([2607:f8b0:4864:20::b31]:38470) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nhUc4-0000AK-BV for qemu-devel@nongnu.org; Thu, 21 Apr 2022 07:04:42 -0400 Received: by mail-yb1-xb31.google.com with SMTP id w133so5395407ybe.5 for ; Thu, 21 Apr 2022 04:04:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5hgpWLWmdwANyTD1HAR+waBtcTBUdinJUaIUV+UMDkU=; b=hFkN9T/sZhfllUH3P/xdHkqEC1EGUfzqlHajM5BBVTMlsPumLKrlZvgoTwc0gWNoUq 2TyAEMqfmE+bCbf+2dIpA41r63mMNxSCZO3vqpG+QB7Qa82W561ab1bRTO+gtxFXS3nd E5wjECf+nuT3+9DlsqdXi5W9WS7tEkCSTSk+tX0vVCKN8yr0rfcwocn/3UPvpMl1UbXl iJKkoE0osp+6+8y/1ATuXk1/L29elLqXH658sx9bHVbNM2NeXIJCGOBJ1wDqNvPlg27A IVeBZKgRL9RapLCU3BYscJ3h87UtT5Sj9sHiPilN21005fPOYT3fii+ZlYGgHJJiGfUZ pIag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5hgpWLWmdwANyTD1HAR+waBtcTBUdinJUaIUV+UMDkU=; b=WFgn9jlWdon49ldyXSkfXBtPUXncy6ovxXI4SeLRVubKDWTRGOKFFbo/r95LygreDO lnLuASVTD15ijOsqkFnk8c0d1IQYI6/Xahs3M2jkPlPDzDRITHjTZ83A/AADmvvSMPNN Js3xrcEkzfUID2Td2av/MEnnlBv8h5YgZVMzlscYp/R+oy8VOqHMufBElTwsgkXdCKpl dl1h4sgw+1SrnaAGRXdCbiO+uu7xpwjgyZlg0n6EtHMcUP3YaMJ/zGUSPfXj/czOdxZS IoDjlYDpoWyJhLGOv+MsCwwZxFcZcol3bNd3JySaXomZreEBgKz/Dloaap7iYPhANT0Z jh1Q== X-Gm-Message-State: AOAM531/48q0d/iIpyYEngEch4WDQIVPvieV/52eN5qKGLt9vHsiQYRl vcBwIe2LHz+hPDsCPMFuQRPNajGDFI7XICbEpKVBTQ== X-Google-Smtp-Source: ABdhPJxyKI3T03eR0r2ciAwc/BKFMgrwxYmV7hmmiRAGiP8vA5enWZV6EZ8bR0lfmJ9AmoGNt8pC0bM/2JQSOQP3ORw= X-Received: by 2002:a25:ccd7:0:b0:641:7c61:de91 with SMTP id l206-20020a25ccd7000000b006417c61de91mr23793108ybf.288.1650539079400; Thu, 21 Apr 2022 04:04:39 -0700 (PDT) MIME-Version: 1.0 References: <20220405223640.2595730-1-wuhaotsh@google.com> <20220405223640.2595730-8-wuhaotsh@google.com> In-Reply-To: <20220405223640.2595730-8-wuhaotsh@google.com> From: Peter Maydell Date: Thu, 21 Apr 2022 12:04:28 +0100 Message-ID: Subject: Re: [PATCH for-7.1 07/11] hw/misc: Support 8-bytes memop in NPCM GCR module To: Hao Wu Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::b31; envelope-from=peter.maydell@linaro.org; helo=mail-yb1-xb31.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Uri.Trichter@nuvoton.com, titusr@google.com, venture@google.com, hskinnemoen@google.com, qemu-devel@nongnu.org, kfting@nuvoton.com, qemu-arm@nongnu.org, Avi.Fishman@nuvoton.com, Vishal.Soni@microsoft.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, 5 Apr 2022 at 23:38, Hao Wu wrote: > > The NPCM8xx GCR device can be accessed with 64-bit memory operations. > This patch supports that. > > Signed-off-by: Hao Wu > Reviewed-by: Patrick Venture > --- > hw/misc/npcm_gcr.c | 98 +++++++++++++++++++++++++++++++++----------- > hw/misc/trace-events | 4 +- > 2 files changed, 77 insertions(+), 25 deletions(-) > > diff --git a/hw/misc/npcm_gcr.c b/hw/misc/npcm_gcr.c > index 14c298602a..aa81db23d7 100644 > --- a/hw/misc/npcm_gcr.c > +++ b/hw/misc/npcm_gcr.c > @@ -201,6 +201,7 @@ static uint64_t npcm_gcr_read(void *opaque, hwaddr offset, unsigned size) > uint32_t reg = offset / sizeof(uint32_t); > NPCMGCRState *s = opaque; > NPCMGCRClass *c = NPCM_GCR_GET_CLASS(s); > + uint64_t value; > > if (reg >= c->nr_regs) { > qemu_log_mask(LOG_GUEST_ERROR, > @@ -209,9 +210,23 @@ static uint64_t npcm_gcr_read(void *opaque, hwaddr offset, unsigned size) > return 0; > } > > - trace_npcm_gcr_read(offset, s->regs[reg]); > + switch (size) { > + case 4: > + value = s->regs[reg]; > + break; > + > + case 8: > + value = s->regs[reg] + (((uint64_t)s->regs[reg + 1]) << 32); > + break; > + > + default: > + g_assert_not_reached(); > + } > > - return s->regs[reg]; > + if (s->regs[reg] != 0) { Why are we now only tracing the read if it's not 0 ? > + trace_npcm_gcr_read(offset, value); > + } > + return value; > } -- PMM