All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Shannon Zhao <zhaoshenglong@huawei.com>
Cc: Wei Huang <wei@redhat.com>,
	QEMU Trivial <qemu-trivial@nongnu.org>,
	Michael Tokarev <mjt@tls.msk.ru>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Shannon Zhao <shannon.zhao@linaro.org>
Subject: Re: [Qemu-devel] [PATCH 1/1] arm: virt: change GPIO trigger interrupt to pulse
Date: Fri, 26 Feb 2016 12:53:02 +0000	[thread overview]
Message-ID: <CAFEAcA-nQuKcONE4GZwavB2w55srvHQP4OxLD6epJaZf4b=agA@mail.gmail.com> (raw)
In-Reply-To: <56D04596.7010205@huawei.com>

On 26 February 2016 at 12:31, Shannon Zhao <zhaoshenglong@huawei.com> wrote:
> So how about below patch? I've tested it and it works both for ACPI and
> DT. Could you help verify if it works for you? Thanks.
>
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index 15658f4..4d45ea2 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -558,11 +558,20 @@ static void create_rtc(const VirtBoardInfo *vbi,
> qemu_irq *pic)
>      g_free(nodename);
>  }
>
> +#define GPIO_KEY_LATENCY 500 /* 500ms */

I don't understand why a 500ms pulse is better than a short one.

> +static QEMUTimer *gpio_key_timer;

This is state, and must be migrated somehow.

thanks
-- PMM

  reply	other threads:[~2016-02-26 12:53 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-28 18:22 [Qemu-devel] [PATCH 1/1] arm: virt: change GPIO trigger interrupt to pulse Wei Huang
2016-01-29 10:10 ` Shannon Zhao
2016-01-29 14:35   ` Wei Huang
2016-01-29 14:46     ` Shannon Zhao
2016-01-29 14:50       ` Wei Huang
2016-01-29 15:22         ` Shannon Zhao
2016-01-29 14:50       ` Peter Maydell
2016-01-29 15:13         ` Wei Huang
2016-01-29 15:29           ` Peter Maydell
2016-02-01 10:17           ` Igor Mammedov
2016-02-01 17:24             ` Wei Huang
2016-01-30  8:18     ` Shannon Zhao
2016-02-03  7:15 ` Michael Tokarev
2016-02-03 10:46   ` Peter Maydell
2016-02-03 16:01     ` Wei Huang
2016-02-04  1:44       ` Shannon Zhao
2016-02-04  6:10         ` Wei Huang
2016-02-04  6:51           ` Shannon Zhao
2016-02-09 22:59             ` Wei Huang
2016-02-20 10:53               ` Shannon Zhao
2016-02-24 22:22                 ` Wei Huang
2016-02-26 12:31                   ` Shannon Zhao
2016-02-26 12:53                     ` Peter Maydell [this message]
2016-02-26 14:54                       ` Shannon Zhao
2016-02-26 15:06                         ` Peter Maydell
2016-02-26 15:28                           ` Wei Huang
2016-02-26 15:42                             ` Peter Maydell
2016-02-27  1:55                               ` Shannon Zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA-nQuKcONE4GZwavB2w55srvHQP4OxLD6epJaZf4b=agA@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=mjt@tls.msk.ru \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=shannon.zhao@linaro.org \
    --cc=wei@redhat.com \
    --cc=zhaoshenglong@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.