Re: [Qemu-devel] New documentation for the LatticeMicro32 target

[Peter Maydell <peter.maydell@linaro.org>]

On 18 July 2017 at 12:44, Michael Walle <michael@walle.cc> wrote:
> Am 2017-07-17 17:18, schrieb Programmingkid:
>> I just tried qemu-system-lm32 and it crashed.
>>
>> Command-line: qemu-system-lm32 -M milkymist -kernel flickernoise
>>
>> Error message: audio: Failed to create voice `mm_ac97.in'
>> **
>> ERROR: /accel/tcg/tcg-all.c:42:tcg_handle_interrupt: assertion failed:
>> (qemu_mutex_iothread_locked())
>> Abort trap: 6
>>
>> Host: Mac OS 10.12.5
>
>
> As I said before, I guess the BQL is missing here. Try the following patch:
>
> diff --git a/target/lm32/op_helper.c b/target/lm32/op_helper.c
> index 2177c8ad12..93b8d09794 100644
> --- a/target/lm32/op_helper.c
> +++ b/target/lm32/op_helper.c
> @@ -102,12 +102,16 @@ void HELPER(wcsr_dc)(CPULM32State *env, uint32_t dc)
>
>  void HELPER(wcsr_im)(CPULM32State *env, uint32_t im)
>  {
> +    qemu_mutex_lock_iothread();
>      lm32_pic_set_im(env->pic_state, im);
> +    qemu_mutex_unlock_iothread();
>  }
>
>  void HELPER(wcsr_ip)(CPULM32State *env, uint32_t im)
>  {
> +    qemu_mutex_lock_iothread();
>      lm32_pic_set_ip(env->pic_state, im);
> +    qemu_mutex_unlock_iothread();
>  }
>
>  void HELPER(wcsr_jtx)(CPULM32State *env, uint32_t jtx)

I just fell over this, it looks like this fix never made it into master.

Michael, could you submit this as a full patch with a commit message
and signed-off-by, please? cc: qemu-stable@nongnu.org as well, since
it fixes a "breaks the board completely" bug.

thanks
-- PMM