From: Peter Maydell <peter.maydell@linaro.org>
To: Eric Blake <eblake@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Patch Tracking <patches@linaro.org>
Subject: Re: [Qemu-devel] [PATCH v2] rules.mak: quiet-command: Split command name and args to print
Date: Thu, 6 Oct 2016 13:33:40 +0100 [thread overview]
Message-ID: <CAFEAcA-r-hzq_mk1DNWiOiJ5hDTH+Wt1=j5pMJuP61Xyq=TmuA@mail.gmail.com> (raw)
In-Reply-To: <2588b35a-822c-a03e-93ef-b25e2ca8e292@redhat.com>
On 4 October 2016 at 20:55, Eric Blake <eblake@redhat.com> wrote:
> On 10/04/2016 11:27 AM, Peter Maydell wrote:
>> The quiet-command make rule currently takes two arguments:
>> the command and arguments to run, and a string to print if
>> the V flag is not set (ie we are not being verbose).
>> By convention, the string printed is of the form
>> " NAME some args". Unfortunately to get nicely lined up
>> output all the strings have to agree about what column the
>> arguments should start in, which means that if we add a
>> new quiet-command usage which wants a slightly longer CMD
>> name then we either put up with misalignment or change
>> every quiet-command string.
>>
>
>>
>> Changes v1->v2:
>> * rebased on master, one new use of quiet-command updated
>> * in pc-bios/optionrom/Makefile and pc-bios/s390-ccw/Makefile,
>> use "BUILD" and "SIGN" for consistency (and to avoid 8-letter word)
>> * improved consistency somewhat by not putting spaces after
>> comma before "THING" strings
>> * tidy "LD -r" printed for .mo link to plain "LD"
>
> I reviewed the interdiff between v1 and v2, and am satisfied enough to add:
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
Applied to master, thanks.
-- PMM
prev parent reply other threads:[~2016-10-06 12:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-04 16:27 [Qemu-devel] [PATCH v2] rules.mak: quiet-command: Split command name and args to print Peter Maydell
2016-10-04 19:55 ` Eric Blake
2016-10-06 12:33 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA-r-hzq_mk1DNWiOiJ5hDTH+Wt1=j5pMJuP61Xyq=TmuA@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=eblake@redhat.com \
--cc=patches@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.