From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53669)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1X0ApD-0000aO-RE
	for qemu-devel@nongnu.org; Thu, 26 Jun 2014 10:39:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1X0Ap8-0005Sa-35
	for qemu-devel@nongnu.org; Thu, 26 Jun 2014 10:38:55 -0400
Received: from mail-lb0-f177.google.com ([209.85.217.177]:54857)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1X0Ap7-0005SA-T8
	for qemu-devel@nongnu.org; Thu, 26 Jun 2014 10:38:50 -0400
Received: by mail-lb0-f177.google.com with SMTP id u10so2976718lbd.22
	for <qemu-devel@nongnu.org>; Thu, 26 Jun 2014 07:38:47 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1403355502-12288-11-git-send-email-pbonzini@redhat.com>
References: <1403355502-12288-1-git-send-email-pbonzini@redhat.com>
	<1403355502-12288-11-git-send-email-pbonzini@redhat.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Thu, 26 Jun 2014 15:38:26 +0100
Message-ID: <CAFEAcA-rLaS_eLA4rQrSuhVQa3_wa_Sv9unHiZn3WuzcaAtbZQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH v3 10/11] target-arm: reorganize
 gen_aa32_ld/st to prepare for BE32 system emulation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>

On 21 June 2014 13:58, Paolo Bonzini <pbonzini@redhat.com> wrote:
> Extract everything to an inline function and simplify DO_GEN_LD/DO_GEN_ST.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

>  DO_GEN_LD(8s, MO_SB)
>  DO_GEN_LD(8u, MO_UB)
>  DO_GEN_LD(16s, MO_SW)
>  DO_GEN_LD(16u, MO_UW)
> -DO_GEN_LD(32u, MO_UL)
>  DO_GEN_ST(8, MO_UB)
>  DO_GEN_ST(16, MO_UW)
> +DO_GEN_LD(32u, MO_UL)
>  DO_GEN_ST(32, MO_UL)

Why move this DO_GEN_LD invocation in amongst the DO_GEN_STs?

Otherwise
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

-- PMM