From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46018) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aNiHt-0004Wm-DJ for qemu-devel@nongnu.org; Mon, 25 Jan 2016 09:38:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aNiHs-0005pv-9u for qemu-devel@nongnu.org; Mon, 25 Jan 2016 09:38:37 -0500 Received: from mail-vk0-x236.google.com ([2607:f8b0:400c:c05::236]:32969) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aNiHs-0005ph-5K for qemu-devel@nongnu.org; Mon, 25 Jan 2016 09:38:36 -0500 Received: by mail-vk0-x236.google.com with SMTP id e64so75295779vkg.0 for ; Mon, 25 Jan 2016 06:38:36 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20160125140038.GK32205@voom.redhat.com> References: <1453684527-23564-1-git-send-email-david@gibson.dropbear.id.au> <20160125111936.GI32205@voom.redhat.com> <20160125140038.GK32205@voom.redhat.com> From: Peter Maydell Date: Mon, 25 Jan 2016 14:38:15 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 00/28] ppc-for-2.6 queue 20160125 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: Laurent Vivier , Thomas Huth , Mark Cave-Ayland , Alexander Graf , QEMU Developers , "qemu-ppc@nongnu.org" , "bharata@linux.vnet.ibm.com" , Greg Kurz On 25 January 2016 at 14:00, David Gibson wro= te: > On Mon, Jan 25, 2016 at 11:59:22AM +0000, Peter Maydell wrote: >> On 25 January 2016 at 11:19, David Gibson = wrote: >> > I think I've fixed it, but it's a bit hard to tell since for me >> > origin/master also fails to compile on 32-bit :(. >> >> Oops -- what's the failure there? >> >> (I do know of a vixl compile failure with older gcc you might be running >> into; if that's it try configuring with --cxx=3Dnone. I should send a pa= tch >> to fix that.) > > Doesn't look like it. Might be something to do with a specific glib > version though: > > $ make -k > CC qga/commands-posix.o > qga/commands-posix.c: In function =E2=80=98qmp_guest_file_write=E2=80=99: > qga/commands-posix.c:529:39: error: passing argument 3 of =E2=80=98qbase6= 4_decode=E2=80=99 from incompatible pointer type [-Werror=3Dincompatible-po= inter-types] > buf =3D qbase64_decode(buf_b64, -1, &buf_len, errp); > ^ > In file included from qga/commands-posix.c:32:0: > /home/dwg/src/qemu/include/qemu/base64.h:52:10: note: expected =E2=80=98s= ize_t * {aka unsigned int *}=E2=80=99 but argument is of type =E2=80=98gsiz= e * {aka long unsigned int *}=E2=80=99 > uint8_t *qbase64_decode(const char *input, > ^ > cc1: all warnings being treated as errors > /home/dwg/src/qemu/rules.mak:57: recipe for target 'qga/commands-posix.o'= failed > make: *** [qga/commands-posix.o] Error 1 > CC util/base64.o Ah, that's your compile environment being wrong -- you're trying to build QEMU 32-bit but using the 64-bit glib headers. Daniel sent a patch which diagnoses this at the configure stage http://patchwork.ozlabs.org/patch/544254/ but it looks like it didn't get applied... Try setting PKG_CONFIG_LIBDIR and perhaps other things. thanks -- PMM