From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:45000)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1RdMYe-00045U-OF
	for qemu-devel@nongnu.org; Wed, 21 Dec 2011 08:50:17 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1RdMYY-0007ZG-P0
	for qemu-devel@nongnu.org; Wed, 21 Dec 2011 08:50:12 -0500
Received: from mail-qw0-f45.google.com ([209.85.216.45]:53552)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1RdMYY-0007Xv-MQ
	for qemu-devel@nongnu.org; Wed, 21 Dec 2011 08:50:06 -0500
Received: by qadc10 with SMTP id c10so3632852qad.4
	for <qemu-devel@nongnu.org>; Wed, 21 Dec 2011 05:50:05 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <1324295617-5798-5-git-send-email-e.voevodin@samsung.com>
References: <1324295617-5798-1-git-send-email-e.voevodin@samsung.com>
	<1324295617-5798-5-git-send-email-e.voevodin@samsung.com>
Date: Wed, 21 Dec 2011 13:50:05 +0000
Message-ID: <CAFEAcA-sNRtTQY1B_f27hNG9OhjReykY1-mk9Nu3iZtR_1z9mA@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v4 04/11] ARM: exynos4210: IRQ subsystem
	support.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Evgeny Voevodin <e.voevodin@samsung.com>
Cc: m.kozlov@samsung.com, qemu-devel@nongnu.org, d.solodkiy@samsung.com

On 19 December 2011 11:53, Evgeny Voevodin <e.voevodin@samsung.com> wrote:

> +static uint64_t exynos4210_gic_cpu_read(void *opaque, target_phys_addr_t=
 offset,
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0unsigned size)
> +{
> + =C2=A0 =C2=A0Exynos4210GicState *s =3D (Exynos4210GicState *) opaque;
> + =C2=A0 =C2=A0DPRINTF_EXYNOS4210_GIC("CPU%d: read offset 0x%x\n",
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0gic_get_current_cpu(), offset)=
;
> + =C2=A0 =C2=A0return gic_cpu_read(&s->gic, gic_get_current_cpu(), offset=
 & ~0x8000);
> +}

arm_gic.c exposes the CPU and distributor interfaces as their own
memory regions now -- you shouldn't need any of this intermediate
layer of functions.

(Reviewing the rest of this series is on my todo list but I can't
guarantee I'll get to it until after Christmas now.)

-- PMM