All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: P J P <ppandit@redhat.com>
Cc: "Jason Wang" <jasowang@redhat.com>,
	"Gaoning Pan" <pgn@zju.edu.cn>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"QEMU Developers" <qemu-devel@nongnu.org>
Subject: Re: [PATCH v3] net: remove an assert call in eth_get_gso_type
Date: Mon, 26 Oct 2020 09:59:47 +0000	[thread overview]
Message-ID: <CAFEAcA-sSk+4v5XDUTapV8qKu-Lv2v87q7+_NUqtxoM50PQnAg@mail.gmail.com> (raw)
In-Reply-To: <nycvar.YSQ.7.78.906.2010211440290.1506567@xnncv>

On Wed, 21 Oct 2020 at 10:23, P J P <ppandit@redhat.com> wrote:
>
> +-- On Wed, 21 Oct 2020, Jason Wang wrote --+
> | It should not be a guest error, since guest is allowed to send a packet
> | other than IPV4(6).
>
> * Ah...sigh! :(
>
> * I very hesitantly used guest_error mask, since it was g_assert-ing before.
>   To me both guest_error and log_unimp seem mismatching. Because no GSO is
>   also valid IIUC. That's why in patch v2 I used plain qemu_log(). But plain
>   qemu_log is also not good it seems.

Well, as I said last time round, the right function depends on what
is going on here. If this is "the fallback code path is fine, it
might just be a bit inefficient", then either no logging or use
a tracepoint. If this is "the guest is allowed to send this packet
but we're going to mishandle it" then use LOG_UNIMP.

thanks
-- PMM


  parent reply	other threads:[~2020-10-26 10:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-21  6:05 [PATCH v3] net: remove an assert call in eth_get_gso_type P J P
2020-10-21  7:44 ` Jason Wang
2020-10-21  9:23   ` P J P
2020-10-26  3:30     ` Jason Wang
2020-10-26  9:59     ` Peter Maydell [this message]
2020-10-28  2:25       ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA-sSk+4v5XDUTapV8qKu-Lv2v87q7+_NUqtxoM50PQnAg@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=jasowang@redhat.com \
    --cc=pgn@zju.edu.cn \
    --cc=philmd@redhat.com \
    --cc=ppandit@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.