All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: Alexey Perevalov <a.perevalov@samsung.com>,
	heetae82.ahn@samsung.com, Juan Quintela <quintela@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Peter Xu <peterx@redhat.com>,
	QEMU Developers <qemu-devel@nongnu.org>,
	i.maximets@samsung.com
Subject: Re: [Qemu-devel] [PATCH] Makefile: don't use LINKPROG for tests/migration/stress
Date: Mon, 2 Oct 2017 12:19:54 +0100	[thread overview]
Message-ID: <CAFEAcA-t+RpfHQCNfLNhn-eGwS6H86yqHURFSura6_oDUOiEHQ@mail.gmail.com> (raw)
In-Reply-To: <20171002111739.GH27086@redhat.com>

On 2 October 2017 at 12:17, Daniel P. Berrange <berrange@redhat.com> wrote:
> On Mon, Oct 02, 2017 at 12:14:39PM +0100, Peter Maydell wrote:
>> Why does this executable need to define its own link rule anyway?
>> Ideally it should just use the standard rules.mak LINK function
>> like everything else. If it does need to do something weird
>> it should have a comment saying why it's weird...
>
> Primarily because we're static linking this binary so that it can be put
> into an initrd without needing any extra files added. It doesn't use any
> of the 3rd party libraries the rest of QEMU uses - ie no glib2 in particular.

Oh, are we committing our usual error of trying to build guest
binaries with the host toolchain?

thanks
-- PMM

  reply	other threads:[~2017-10-02 11:20 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20170929101124eucas1p25695c76db8f17ef8181ee2b3051bba98@eucas1p2.samsung.com>
2017-09-29 10:11 ` [Qemu-devel] [PATCH] fix tests/migration/stress build Alexey Perevalov
     [not found]   ` <CGME20170929101125eucas1p1ed4a290bfc6fcbf6f492fc45d4e9cc10@eucas1p1.samsung.com>
2017-09-29 10:11     ` [Qemu-devel] [PATCH] configure: correctly define PTHREAD_LIB Alexey Perevalov
2017-09-29 10:40       ` Daniel P. Berrange
2017-09-29 12:52         ` Alexey Perevalov
2017-09-29 13:05           ` Daniel P. Berrange
2017-09-29 13:47             ` Alexey Perevalov
2017-09-29 14:38               ` Daniel P. Berrange
     [not found]                 ` <CGME20171002083119eucas1p191b8bdf0c990b86a7290c28b65312b86@eucas1p1.samsung.com>
2017-10-02  8:30                   ` [Qemu-devel] [PATCH] fix tests/migration/stress build in case of absend static libc++ Alexey Perevalov
2017-10-02  8:30                 ` [Qemu-devel] [PATCH] Makefile: don't use LINKPROG for tests/migration/stress Alexey Perevalov
2017-10-02 11:14                   ` Peter Maydell
2017-10-02 11:17                     ` Daniel P. Berrange
2017-10-02 11:19                       ` Peter Maydell [this message]
2017-10-02 11:21                         ` Daniel P. Berrange
2017-09-29 10:46   ` [Qemu-devel] [PATCH] fix tests/migration/stress build Daniel P. Berrange
2017-09-29 15:05     ` Alexey Perevalov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA-t+RpfHQCNfLNhn-eGwS6H86yqHURFSura6_oDUOiEHQ@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=a.perevalov@samsung.com \
    --cc=berrange@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=heetae82.ahn@samsung.com \
    --cc=i.maximets@samsung.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.