From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42951)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1VrAAy-0002ff-QC
	for qemu-devel@nongnu.org; Thu, 12 Dec 2013 12:35:57 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1VrAAt-0003LF-9p
	for qemu-devel@nongnu.org; Thu, 12 Dec 2013 12:35:52 -0500
Received: from mail-pd0-f175.google.com ([209.85.192.175]:47015)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1VrAAs-0003Kz-PT
	for qemu-devel@nongnu.org; Thu, 12 Dec 2013 12:35:47 -0500
Received: by mail-pd0-f175.google.com with SMTP id w10so867803pde.34
	for <qemu-devel@nongnu.org>; Thu, 12 Dec 2013 09:35:46 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <1386279359-32286-8-git-send-email-roy.franz@linaro.org>
References: <1386279359-32286-1-git-send-email-roy.franz@linaro.org>
	<1386279359-32286-8-git-send-email-roy.franz@linaro.org>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Thu, 12 Dec 2013 17:35:25 +0000
Message-ID: <CAFEAcA-tnh24u4EATPbp-i+Mx+sqiXoaJ8ZsyGQUMhyqJ3v+JQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH V5 7/7] Fix NOR flash device ID reading
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Roy Franz <roy.franz@linaro.org>
Cc: Kevin Wolf <kwolf@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>, Patch Tracking <patches@linaro.org>

On 5 December 2013 21:35, Roy Franz <roy.franz@linaro.org> wrote:
> Fix NOR flash manufacturer and device ID reading.  This now
> properly takes into account device widths and device max widths
> as required.  The reading of these IDs uses the same max_width
> dependent addressing as CFI queries.
>
> The old code remains for chips that don't specify a device width,
> as the new code relies on a device width being set in order to
> properly operate.  The existing code seems very broken.
>
> Only ident0 and ident1 are used in the new code, as other fields
> relate to the lock state of blocks in flash.
>
> The VExpress flash configuration has been updated to match
> the new code, as the existing definition was 'wrong' in order
> to return the expected results with the broken device ID code.
>
> Signed-off-by: Roy Franz <roy.franz@linaro.org>

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

-- PMM