From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39715C07E96 for ; Thu, 8 Jul 2021 12:31:00 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DC494613B2 for ; Thu, 8 Jul 2021 12:30:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DC494613B2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44116 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1TBB-0004Qh-IM for qemu-devel@archiver.kernel.org; Thu, 08 Jul 2021 08:30:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:32784) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1T91-0001Qu-25 for qemu-devel@nongnu.org; Thu, 08 Jul 2021 08:28:48 -0400 Received: from mail-ed1-x52d.google.com ([2a00:1450:4864:20::52d]:39589) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m1T8x-0000U6-JW for qemu-devel@nongnu.org; Thu, 08 Jul 2021 08:28:41 -0400 Received: by mail-ed1-x52d.google.com with SMTP id v1so8272847edt.6 for ; Thu, 08 Jul 2021 05:28:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=20K+rheX1py+s36Bbey3G3S12ajGG70059ZQfodWtNo=; b=ThHr7QD8pvjRY3v5LceNjXqPBSFLbJplOVrg7npNeO/IGO/VKoYoQHtK9I8THOCrnz VMwFYFDse2FRUmyF0F2vvL6V/HM/j0jXrwFq8gnIO17qzsWusm6rEHnc6MPHhSPVUsir CjEd9BWsh+xaogG3+hS63fK2Hb3/tq9cWeOdSWs1+znbYCKVBFk7ZibchlmGZ/4hp6cF wxtdH3qj8mMVrotEs4x3BeaLno9Yb/KgKrM2cjd5H4mglfFASjRrUpv8G5gsqh7iqbV8 rurRdJvW7gSWDr3vvExrz5Fy9xJortsOJoa58XwuWYYHg45I3pYhIKD1mPZivfVmyyJV P2PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=20K+rheX1py+s36Bbey3G3S12ajGG70059ZQfodWtNo=; b=kjAZc0H3unqnOU/+qG/XKPVNq7hgeqNJooGt0w2dpkyimAr5e/fvkfr/7BWfNd0eDN RB7xmNI1Tec5qqc0WVbOqvE6WnoM4jIm1U9YhVBHp96aWaAXt61T4B9orFnBCu74RZSI v+p0/e8cS5wxchrFY0nHboc4JwRZnZWLygj89C5qYYXYlvZDkncdCDNh4UEbWoEMlpgx mDjBoph8w32I75+vbKVjwI2m8BIYhia025/PwQ4IK96Mm8Ngqz4kuf168OQa+7/yNeFQ EP84AEl0lCgAa9fUBRphoMuM0LsSGTXm6sux+IKqImwwHnn7NGVCeAVw6ZL4BJNxd5H9 oaDA== X-Gm-Message-State: AOAM532ia3TqNzIMzwiIPoYs9KSXBAzd3uTaADjZn+ETOnPvqhyCiSnI q9/aAF5aIUs5wXiZnczfCdpzuWk3CdBd/oUXSZMWzg== X-Google-Smtp-Source: ABdhPJxkEdWdIKkdNZqet4ADacZmu/v6Blh3lwDRkFnQ4pcWH16W7k18sTIjLdMKjULuk8ybfqe3+8/UO88FFAYlqU8= X-Received: by 2002:aa7:c857:: with SMTP id g23mr36975405edt.100.1625747318009; Thu, 08 Jul 2021 05:28:38 -0700 (PDT) MIME-Version: 1.0 References: <20210630183226.3290849-1-richard.henderson@linaro.org> <20210630183226.3290849-11-richard.henderson@linaro.org> In-Reply-To: <20210630183226.3290849-11-richard.henderson@linaro.org> From: Peter Maydell Date: Thu, 8 Jul 2021 13:27:59 +0100 Message-ID: Subject: Re: [PATCH v2 10/28] target/cris: Use translator_use_goto_tb To: Richard Henderson Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::52d; envelope-from=peter.maydell@linaro.org; helo=mail-ed1-x52d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Edgar E . Iglesias" , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 30 Jun 2021 at 19:43, Richard Henderson wrote: > > The test for singlestepping is done in translator_use_goto_tb, > so we may elide it from cris_tr_tb_stop. > > Cc: Edgar E. Iglesias > Signed-off-by: Richard Henderson > --- > target/cris/translate.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/target/cris/translate.c b/target/cris/translate.c > index 4cfe5c86d9..e33a3bb326 100644 > --- a/target/cris/translate.c > +++ b/target/cris/translate.c > @@ -482,7 +482,7 @@ static void t_gen_swapr(TCGv d, TCGv s) > > static bool use_goto_tb(DisasContext *dc, target_ulong dest) > { > - return ((dest ^ dc->base.pc_first) & TARGET_PAGE_MASK) == 0; > + return translator_use_goto_tb(&dc->base, dest); > } Reviewed-by: Peter Maydell thanks -- PMM