From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51945)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1bDYJj-0004L3-EJ
	for qemu-devel@nongnu.org; Thu, 16 Jun 2016 10:30:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1bDYJc-0006Hs-8t
	for qemu-devel@nongnu.org; Thu, 16 Jun 2016 10:30:46 -0400
Received: from mail-vk0-x22d.google.com ([2607:f8b0:400c:c05::22d]:33695)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1bDYJc-0006HI-4N
	for qemu-devel@nongnu.org; Thu, 16 Jun 2016 10:30:40 -0400
Received: by mail-vk0-x22d.google.com with SMTP id d185so75767510vkg.0
	for <qemu-devel@nongnu.org>; Thu, 16 Jun 2016 07:30:40 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20160615085200.hcqq3nkzug5eicus@hawk.localdomain>
References: <1465960955-17388-1-git-send-email-zhaoshenglong@huawei.com>
	<20160615085200.hcqq3nkzug5eicus@hawk.localdomain>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Thu, 16 Jun 2016 15:30:20 +0100
Message-ID: <CAFEAcA-wv7ccid5D6CxyRUSC1hg8TGXYrP0gRZOPR8AuUyi-9A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH] ACPI: ARM: Present GIC version in MADT
 table
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andrew Jones <drjones@redhat.com>
Cc: Shannon Zhao <zhaoshenglong@huawei.com>, qemu-arm <qemu-arm@nongnu.org>, Igor Mammedov <imammedo@redhat.com>, "Huangpeng (Peter)" <peter.huangpeng@huawei.com>, QEMU Developers <qemu-devel@nongnu.org>, Shannon Zhao <shannon.zhao@linaro.org>

On 15 June 2016 at 09:52, Andrew Jones <drjones@redhat.com> wrote:
> On Wed, Jun 15, 2016 at 11:22:35AM +0800, Shannon Zhao wrote:
>> From: Shannon Zhao <shannon.zhao@linaro.org>
>>
>> In ACPI 5.1 Errata, it adds GIC version in GIC distributor structure.
>> This is useful for guest kernel to identify which version GIC hardware
>> is. Update GIC distributor structure and present GIC version in MADT
>> table.
>>
>> Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>

>
> AFAICT, Linux is actually fine with version=0 (as before this patch).
> One way or another it has already determined that the gic is either v3
> or v4, and then just proceeds. That said, it does seem like the right
> thing to do to set it
>
> Reviewed-by: Andrew Jones <drjones@redhat.com>

Applied to target-arm.next, thanks.

-- PMM