From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59048) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGq2u-0003vW-9v for qemu-devel@nongnu.org; Thu, 29 Jan 2015 09:26:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGq2q-0002wG-WE for qemu-devel@nongnu.org; Thu, 29 Jan 2015 09:26:12 -0500 Received: from mail-lb0-f171.google.com ([209.85.217.171]:62347) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGq2q-0002w8-Pv for qemu-devel@nongnu.org; Thu, 29 Jan 2015 09:26:08 -0500 Received: by mail-lb0-f171.google.com with SMTP id u14so28499207lbd.2 for ; Thu, 29 Jan 2015 06:26:08 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <54CA3CAE.2000902@suse.de> References: <1421857131-18539-1-git-send-email-agraf@suse.de> <1421857131-18539-3-git-send-email-agraf@suse.de> <54CA3CAE.2000902@suse.de> From: Peter Maydell Date: Thu, 29 Jan 2015 14:25:47 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH v2 2/4] pci: Add generic PCIe host bridge List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Rob Herring , "Michael S. Tsirkin" , QEMU Developers , Ard Biesheuvel , Claudio Fontana , Alvise Rigo , Stuart Yoder , Paolo Bonzini On 29 January 2015 at 13:59, Alexander Graf wrote: > On 27.01.15 16:31, Peter Maydell wrote: >> On 21 January 2015 at 16:18, Alexander Graf wrote: >>> + dc->vmsd = &vmstate_gpex_root; >>> + k->vendor_id = PCI_VENDOR_ID_REDHAT; >>> + k->device_id = PCI_DEVICE_ID_REDHAT_BRIDGE; >> >> Pretty sure we shouldn't be reusing the PCI bridge IDs >> for a host bridge. We should allocate ourselves another >> device ID in the range... > > Ah, right, I forgot about that. Unfortunately I can't reserve PCI IDs in > the Red Hat PCI range. > > Michael, what's the process here? Last time this came up I think Paolo said the official registration was getting a patch into QEMU master that added a line to the list in pci.h :-) [ie QEMU is the master source for these IDs] -- PMM