From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:43170)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1RuuUP-00067t-SV
	for qemu-devel@nongnu.org; Tue, 07 Feb 2012 18:30:25 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1RuuUL-0007Yl-M4
	for qemu-devel@nongnu.org; Tue, 07 Feb 2012 18:30:21 -0500
Received: from mail-qw0-f45.google.com ([209.85.216.45]:57318)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1RuuUL-0007Yf-HH
	for qemu-devel@nongnu.org; Tue, 07 Feb 2012 18:30:17 -0500
Received: by qabg40 with SMTP id g40so3222372qab.4
	for <qemu-devel@nongnu.org>; Tue, 07 Feb 2012 15:30:16 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <4F31A0B6.8040408@suse.de>
References: <1328237992-14953-1-git-send-email-afaerber@suse.de>
	<1328237992-14953-14-git-send-email-afaerber@suse.de>
	<CAFEAcA9_zJxYn7PkHqCKdT=14ngBqRQhw2m+iEHofq6gh7yd4A@mail.gmail.com>
	<4F317056.5030804@suse.de>
	<CAFEAcA8XAwWwAQ3TSJo+KiVHBTyXQXjF1eH9hrd6xuy_PRh0Og@mail.gmail.com>
	<4F31A0B6.8040408@suse.de>
Date: Tue, 7 Feb 2012 23:30:16 +0000
Message-ID: <CAFEAcA-yQc8O-Xh0YipEYQ=efgrpt0B_uB4-OR9GXDD83gszsQ@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH RFC v3 13/21] target-arm: Store JTAG_ID in
	ARMCPUClass
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?Q?Andreas_F=C3=A4rber?= <afaerber@suse.de>
Cc: qemu-devel@nongnu.org

On 7 February 2012 22:07, Andreas F=C3=A4rber <afaerber@suse.de> wrote:
> Am 07.02.2012 20:06, schrieb Peter Maydell:
>> On 7 February 2012 18:41, Andreas F=C3=A4rber <afaerber@suse.de> wrote:
>>> Andrzej will have had his reasons to put it in the code. This series
>>> just moves code around so I don't want to remove it without his ack.
>>
>> That was my point -- as far as I can see this patch *is* adding code
>> and a struct field that wasn't there before.
>
> Huh? Look closely, it *was* a comment in the original code.

Exactly. It was a comment; now it's code. I don't think we should
be adding code.

> And I don't want to *move* that comment over into my new code.

You can move the comment, or you can just drop it; I'm happy with
either. I don't want new code/struct fields we don't use.

-- PMM